[13.x] Replace __wakeup with __unserialize (deprecated in PHP 8.5) #57021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'limiterName', | ||
| 'shouldRelease', | ||
| 'limiterName' => $this->limiterName, | ||
| 'shouldRelease' => $this->shouldRelease, |
There was a problem hiding this comment.
We should take the opportunity to add the $releaseAfter property.
It was added in PR #55671 but missed being added on the serialization at the time.
|
imo it should not target 12.x |
That is right, especially as one could be overriding |
arshidkv12
changed the title
arshidkv12
force-pushed
the
__wakeup__
branch
from
0ae7be5 to
7bb0f55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy
__wakeup()method is deprecated as of PHP 8.5 in favor of__unserialize().These newer methods provide more flexible and explicit control over object unserialization.
https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_the_sleep_and_wakeup_magic_methods
#57018