Skip to content

Conversation

Yang-33
Copy link
Contributor

@Yang-33 Yang-33 commented Apr 5, 2025

This update allows additional headers to be set from the bot SDK's client. The behavior is as follows:

  1. Non-critical headers, such as the user agent, can be overwritten.
  2. critical header like authorization headers cannot be overriden.

The goal is to allow the user agent to be overwritten when using this in other projects. Since it doesn't need to be limited to the user agent header, it has been implemented more generally.

@Yang-33 Yang-33 marked this pull request as ready for review April 5, 2025 14:36
@Yang-33 Yang-33 requested a review from a team April 5, 2025 14:36
@Yang-33 Yang-33 self-assigned this Apr 5, 2025
Copy link
Contributor

@eucyt eucyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Yang-33 Yang-33 added this pull request to the merge queue Apr 7, 2025
Merged via the queue into line:master with commit 75d5da0 Apr 7, 2025
7 checks passed
@Yang-33 Yang-33 deleted the allow-to-inject-default-header-from-each-client branch April 7, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants