Skip to content

Conversation

oronila
Copy link
Contributor

@oronila oronila commented May 7, 2025

Closes #1801

@oronila oronila requested a review from stgraber as a code owner May 7, 2025 00:06
@stgraber stgraber force-pushed the stable-test-final-pr branch from d3c679a to 4652a05 Compare May 29, 2025 17:22
@stgraber stgraber added this to the incus-6.14 milestone May 29, 2025
@stgraber
Copy link
Member

I did a few tweaks on this one but I'm out of time to get this into today's release so it will go onto next month's.

The PR was missing one pretty important change, the removal of the old functions.
Once I did that, things mostly behaved but it's missing a compatible implementation of the Create logic. Getting the basics done is pretty straightforward but getting the peering+linking logic to match the old logic, that's a bit harder and not something I want to rush in hours before a release.

@stgraber stgraber force-pushed the stable-test-final-pr branch 2 times, most recently from 6569637 to 1312104 Compare June 18, 2025 04:18
@stgraber
Copy link
Member

Okay, I had to do a bunch more changes to the generator functions to get this to behave.
I still need to run this through our OVN testsuite to make sure that the peer logic actually functions.

@stgraber stgraber force-pushed the stable-test-final-pr branch from 1312104 to 134abb3 Compare June 19, 2025 04:41
@stgraber
Copy link
Member

Fixed a bunch more regressions, now clearing our OVN testsuite so hopefully we're good to go with this one now.

@stgraber stgraber merged commit 22b5447 into lxc:main Jun 19, 2025
68 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Port network_peers to the database generator
2 participants