Fix security issue due to rule ordering in nftables (ACLs + isolation) #2222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit d137a06 changed the rule ordering and bypassed some of the MAC/IPv4/IPv6 filtering. This made possible to ARP spoof another VM/container and fully spoof it on a bridge. This is a security fix: - CVE-2025-52890 - GHSA-p7fw-vjjm-2rwp Signed-off-by: Olivier Bal-Petre <[email protected]> Acked-by: Stéphane Graber <[email protected]>
Commit a7c3330 added basic rules that bypass some of the MAC/IPv4/IPv6 filtering, allowing to exhaust the DHCP pool and open the door for other attacks on the bridge. This is a security fix: - CVE-2025-52889 - GHSA-9q7c-qmhm-jv86 Signed-off-by: Olivier Bal-Petre <[email protected]> Acked-by: Stéphane Graber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of recent regressions (Incus 6.12 and 6.13) in how isolation rules are applied when combined with ACLs. Those specifically affect environments using
nftablesandbridgenetworking alongside the aforementioned isolation rules.Thanks to Olivier BAL-PETRE of ANSSI (French Cybersecurity Agency) for reporting those and providing fixes for both issues!
Relevant security issues: