Skip to content

Allow setting user.* on the root disk when the VM is running #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2025
Merged

Allow setting user.* on the root disk when the VM is running #2304

merged 3 commits into from
Jul 25, 2025

Conversation

presztak
Copy link
Collaborator

@presztak presztak commented Jul 24, 2025 •
edited
Loading

  1. Set diskLimits as nil if read/write limits are not set.
  2. Don't call deviceAttachBlockDevice on the root disk.
  3. Fix issue with checking 'user.' keys. Previously compared to device name, causing unwanted device add/remove

Fixes: #2243

@presztak presztak marked this pull request as ready for review July 24, 2025 09:27
@presztak presztak requested a review from stgraber as a code owner July 24, 2025 09:27
@presztak presztak marked this pull request as draft July 24, 2025 13:00
@presztak presztak marked this pull request as ready for review July 25, 2025 11:36
@stgraber stgraber merged commit f07ff65 into lxc:main Jul 25, 2025
36 of 38 checks passed
@presztak presztak deleted the user_key_fail branch July 28, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber Awaiting requested review from stgraber stgraber is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting user.* on a VM's root disk fails if the VM is running
2 participants
@presztak @stgraber