-
Notifications
You must be signed in to change notification settings - Fork 227
Add fontExtensions
configuration option. (mathjax/MathJax#3410)
#1337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1337 +/- ##
===========================================
- Coverage 86.72% 86.71% -0.02%
===========================================
Files 337 337
Lines 84145 84185 +40
Branches 4769 4773 +4
===========================================
+ Hits 72971 72997 +26
- Misses 11151 11165 +14
Partials 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I added a commit that includes support for generic font extensions that have dynamic font ranges, like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
I just realized there is a potential problem, here. If there is a retry during the |
I've added the error checking. Do you want to re-review? |
This PR adds a
fontExtensions
configuration that makes it easier to specify a font extension to load (e.g.,mathjax-euler
). It sets up theextraLoads
package data to make sure the extension loads after the font itself. The current method of including the extension in theloader.load
array doesn't work properly as it can be loaded before the font arrives. That can be handled by setting up dependencies and paths in the loader configuration, but it is harder than it should be, so this makes it easy.Resolves issue mathjax/MathJax#3410.
The original section that was used to configure a font has been moved to a
configFont()
function, and a newconfigExtensions()
function uses it to set up the font extensions.