pkgconfig: Fix class cached to be keyed on extra_paths #15001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `extra_paths` to cache keys for `PkgConfigInterface` and `PkgConfigCLI` instances, to avoid incorrectly reusing an instance with a different `extra_paths` value, see: mesonbuild#14657 (comment) Signed-off-by: Michał Górny <[email protected]>
|
Gentle ping. |
dcbaker
approved these changes
Sep 19, 2025
|
@eli-schwartz This might be a candidate for 1.9.x, what do you think? |
|
From pure eyeballing alone, I think this will probably break existing build directories and need the forced reconfigure from scratch with dropped caches that is specific to major.minor version changes. |
|
Yeah, that's true. Okay, so we'll leave it for 1.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
extra_pathsto cache keys forPkgConfigInterfaceandPkgConfigCLIinstances, to avoid incorrectly reusing an instance with a differentextra_pathsvalue, see:#14657 (comment)