modules/windows: Also search for llvm-rc and llvm-windres #15017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lb90
force-pushed
the
windows-module-search-llvm-rc-and-llvm-windres
branch
from
24afaa8 to
8414c9f
Compare
lb90
force-pushed
the
windows-module-search-llvm-rc-and-llvm-windres
branch
from
8414c9f to
0fad600
Compare
eli-schwartz
requested changes
Sep 16, 2025
| if comp.id in {'msvc', 'clang-cl', 'intel-cl'} or (comp.linker and comp.linker.id in {'link', 'lld-link'}): | ||
| # Microsoft compilers uses rc irrespective of the frontend | ||
| rescomp = ExternalProgram('rc', silent=True) | ||
| rescomp = find_rc_like_compiler() or find_windres_like_compiler() |
There was a problem hiding this comment.
The commit message doesn't rationalize why for MSVC/clang-cl we now search for windres
| return None | ||
|
|
||
| def find_rc_like_compiler() -> T.Optional[ExternalProgram]: | ||
| return search_programs(['rc', 'llvm-rc']) |
There was a problem hiding this comment.
This function exists solely to be an alias for another function. I don't think you need the extra function definition...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15011