Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
495d8e6
Add OpenApiTypeMapper that maps .NET primitive types to the OpenAPI s…
MaggieKimani1 Dec 1, 2022
83db702
Add test and update public API interface
MaggieKimani1 Dec 1, 2022
0b141fa
Map OpenApiSchema types to simple type and add test to validate
MaggieKimani1 Dec 6, 2022
dca3151
Update Uri format
MaggieKimani1 Dec 6, 2022
2ad17ba
Update type and format to lowercase
MaggieKimani1 Dec 6, 2022
0b4110a
Fix failing tests
MaggieKimani1 Dec 6, 2022
2139d99
Merge pull request #1094 from microsoft/mk/generate-schema-for-pocos
MaggieKimani1 Dec 6, 2022
1a7392f
Serialize `OpenApiDate` values properly to short date (#1102)
irvinesunday Dec 8, 2022
48a809e
check Extensions object for null
quanterion Dec 9, 2022
ebbe5c1
Merge pull request #1104 from quanterion/patch-1
baywet Dec 9, 2022
e971a7a
Bump Microsoft.OData.Edm from 7.12.5 to 7.13.0
dependabot[bot] Dec 9, 2022
ac02124
Merge pull request #1105 from microsoft/dependabot/nuget/Microsoft.OD…
baywet Dec 11, 2022
74db965
Enable termination of transform process
MaggieKimani1 Dec 14, 2022
49158be
Bump Microsoft.OpenApi.OData from 1.2.0-preview8 to 1.2.0-preview9
dependabot[bot] Dec 15, 2022
e8d3e80
Merge pull request #1109 from microsoft/dependabot/nuget/Microsoft.Op…
baywet Dec 16, 2022
07f0edf
Bump Microsoft.NET.Test.Sdk from 17.4.0 to 17.4.1
dependabot[bot] Dec 16, 2022
8ce4ec5
Merge pull request #1110 from microsoft/dependabot/nuget/Microsoft.NE…
baywet Dec 16, 2022
7867fdd
Use an IConsole instance to register and handle cancellation when CTR…
MaggieKimani1 Dec 19, 2022
6c1e502
Pass cancellation token to the conversion method and degrade graceful…
MaggieKimani1 Dec 19, 2022
5d8ef7f
Clean up code
MaggieKimani1 Dec 19, 2022
05256dd
Fix failing tests
MaggieKimani1 Dec 19, 2022
214774b
Update src/Microsoft.OpenApi.Hidi/Handlers/TransformCommandHandler.cs
baywet Dec 19, 2022
4a163a6
Code clean up
MaggieKimani1 Dec 19, 2022
760445c
Merge pull request #1108 from microsoft/mk/terminate-process
MaggieKimani1 Dec 19, 2022
f205c36
Bump Verify.Xunit from 19.3.0 to 19.5.0
dependabot[bot] Dec 19, 2022
db08157
Merge pull request #1111 from microsoft/dependabot/nuget/Verify.Xunit…
baywet Dec 19, 2022
48fbe51
Bump Moq from 4.18.3 to 4.18.4
dependabot[bot] Dec 30, 2022
776c156
Merge pull request #1115 from microsoft/dependabot/nuget/Moq-4.18.4
baywet Dec 30, 2022
006bcf2
verify string writer
SimonCropp Dec 31, 2022
81bcd3c
Merge pull request #1116 from SimonCropp/verify-string-writer
baywet Dec 31, 2022
e517053
Added show command
darrelmiller Dec 23, 2022
49a12f3
Moved mermaid writer into OpenApiUrlTreeNode and fixed more sanitizat…
darrelmiller Dec 23, 2022
8781884
Added shapes for better accessibility
darrelmiller Dec 24, 2022
0bc1726
Update to do a unnecessary using
darrelmiller Dec 25, 2022
e8061ac
Update src/Microsoft.OpenApi/Services/OpenApiUrlTreeNode.cs
darrelmiller Dec 25, 2022
5a7146c
Update src/Microsoft.OpenApi/Services/OpenApiUrlTreeNode.cs
darrelmiller Dec 25, 2022
fc3ba5e
Added a bunch of usings and removed an unnecessary flush to address c…
darrelmiller Dec 25, 2022
6c57e8d
Fixed broken order method
darrelmiller Dec 25, 2022
9e2ff51
Update src/Microsoft.OpenApi/Services/OpenApiUrlTreeNode.cs
darrelmiller Dec 28, 2022
efeeca7
Update src/Microsoft.OpenApi/Services/OpenApiUrlTreeNode.cs
darrelmiller Dec 28, 2022
5d87820
Update src/Microsoft.OpenApi/Services/OpenApiUrlTreeNode.cs
darrelmiller Dec 28, 2022
674fe14
Changed mermaid styles to make them readonly
darrelmiller Jan 3, 2023
931270f
Fixed data in broken test
darrelmiller Jan 4, 2023
079da0f
Updated public API
darrelmiller Jan 4, 2023
2783cb7
- bumps hidi version to get latest odata and mermaid
baywet Jan 4, 2023
9858a80
Revert "Serialize `OpenApiDate` values properly to short date (#1102)"
MaggieKimani1 Jan 5, 2023
d8e2fdf
Merge pull request #1117 from microsoft/feature/hidi-bump
baywet Jan 5, 2023
70724b5
Fix failing test by updating operation id
MaggieKimani1 Jan 5, 2023
fa86d4f
Write out the corresponding DateTime value as a short date representa…
MaggieKimani1 Jan 5, 2023
6d21b49
Fix tests
MaggieKimani1 Jan 5, 2023
a0d002a
Upgrade lib versions
MaggieKimani1 Jan 5, 2023
2223574
Fix failing test
MaggieKimani1 Jan 5, 2023
04a4880
Merge pull request #1119 from microsoft/mk/upgrade-lib-versions
MaggieKimani1 Jan 5, 2023
70a5b57
Merge branch 'vnext' into revert-1102-is/fix-date-serialization
MaggieKimani1 Jan 5, 2023
c8e107d
Merge pull request #1118 from microsoft/revert-1102-is/fix-date-seria…
MaggieKimani1 Jan 5, 2023
3f59784
Refactored OpenAPIService to remove duplicate code
darrelmiller Jan 5, 2023
e0d08f8
Added tests for mermaid diagrams
darrelmiller Jan 8, 2023
b61edcf
Updated diagram test to cover more scenarios
darrelmiller Jan 9, 2023
6877019
Bump Verify.Xunit from 19.5.0 to 19.6.0
dependabot[bot] Jan 9, 2023
9a462d4
Merge pull request #1123 from microsoft/dependabot/nuget/Verify.Xunit…
baywet Jan 9, 2023
6a53f24
Merge remote-tracking branch 'origin/vnext' into dm/show
darrelmiller Jan 11, 2023
8a9305b
Added test for show command
darrelmiller Jan 11, 2023
b0af526
Refactored to improve test coverage
darrelmiller Jan 12, 2023
776e98f
Change test to call sync invoke
darrelmiller Jan 12, 2023
5bc0bd4
Added back missing parameter config options in parseopenapi
darrelmiller Jan 12, 2023
bf2d122
Bump FluentAssertions from 6.8.0 to 6.9.0
dependabot[bot] Jan 13, 2023
8c08c06
Bump Microsoft.OData.Edm from 7.13.0 to 7.14.0
dependabot[bot] Jan 13, 2023
905293e
Merge pull request #1129 from microsoft/dependabot/nuget/Microsoft.OD…
baywet Jan 14, 2023
4ba2d8b
Merge pull request #1128 from microsoft/dependabot/nuget/FluentAssert…
baywet Jan 14, 2023
5ee6095
Updated SanitizeMermaidNode to handle cases found in Microsoft Graph …
darrelmiller Jan 15, 2023
a7c4983
Removed Task.Delay as no longer necessary. #1127
darrelmiller Jan 15, 2023
7aac03f
Updated commands to enable reading from CSDL url for both transform a…
darrelmiller Jan 15, 2023
8e2d470
Used random file in a hidi folder to address security concerns.
darrelmiller Jan 15, 2023
c23694c
Fixed code smell relating to LogError
darrelmiller Jan 15, 2023
6a3dd01
Added test to call Transform command directly so that code coverage w…
darrelmiller Jan 15, 2023
8ff70a1
Removed unnecessary test that was breaking
darrelmiller Jan 16, 2023
b95cda3
This time I included the change
darrelmiller Jan 16, 2023
230af2f
Added missing comments for public APIs
darrelmiller Jan 16, 2023
2b82a74
Added more tests to meet the coverage gods
darrelmiller Jan 16, 2023
4537239
More sacrifices made
darrelmiller Jan 16, 2023
ff55439
Bump docker/build-push-action from 3.2.0 to 3.3.0
dependabot[bot] Jan 16, 2023
09b5c9f
Merge pull request #1130 from microsoft/dependabot/github_actions/doc…
baywet Jan 16, 2023
96fae88
Will these be the tests that achieve the magical goal?
darrelmiller Jan 16, 2023
7638805
I am confidence I have enough tests now
darrelmiller Jan 16, 2023
a8a693d
Added a using to dispose a StreamReader
darrelmiller Jan 16, 2023
95e598b
Merge pull request #1113 from microsoft/dm/show
darrelmiller Jan 17, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ jobs:
id: getversion
- name: Push to GitHub Packages - Nightly
if: ${{ github.ref == 'refs/heads/vnext' }}
uses: docker/build-push-action@v3.2.0
uses: docker/build-push-action@v3.3.0
with:
push: true
tags: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:nightly
- name: Push to GitHub Packages - Release
if: ${{ github.ref == 'refs/heads/master' }}
uses: docker/build-push-action@v3.2.0
uses: docker/build-push-action@v3.3.0
with:
push: true
tags: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest,${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ steps.getversion.outputs.version }}
56 changes: 56 additions & 0 deletions src/Microsoft.OpenApi.Hidi/Handlers/ShowCommandHandler.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT license.

using System;
using System.CommandLine;
using System.CommandLine.Invocation;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Extensions.Logging;

namespace Microsoft.OpenApi.Hidi.Handlers
{
internal class ShowCommandHandler : ICommandHandler
{
public Option<string> DescriptionOption { get; set; }
public Option<FileInfo> OutputOption { get; set; }
public Option<LogLevel> LogLevelOption { get; set; }
public Option<string> CsdlOption { get; set; }
public Option<string> CsdlFilterOption { get; set; }


public int Invoke(InvocationContext context)
{
return InvokeAsync(context).GetAwaiter().GetResult();
}
public async Task<int> InvokeAsync(InvocationContext context)
{
string openapi = context.ParseResult.GetValueForOption(DescriptionOption);
FileInfo output = context.ParseResult.GetValueForOption(OutputOption);
LogLevel logLevel = context.ParseResult.GetValueForOption(LogLevelOption);
string csdlFilter = context.ParseResult.GetValueForOption(CsdlFilterOption);
string csdl = context.ParseResult.GetValueForOption(CsdlOption);
CancellationToken cancellationToken = (CancellationToken)context.BindingContext.GetService(typeof(CancellationToken));

using var loggerFactory = Logger.ConfigureLogger(logLevel);
var logger = loggerFactory.CreateLogger<OpenApiService>();
try
{
await OpenApiService.ShowOpenApiDocument(openapi, csdl, csdlFilter, output, logger, cancellationToken);

return 0;
}
catch (Exception ex)
{
#if DEBUG
logger.LogCritical(ex, ex.Message);
throw; // so debug tools go straight to the source of the exception when attached
#else
logger.LogCritical( ex.Message);
return 1;
#endif
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,14 @@ public async Task<int> InvokeAsync(InvocationContext context)
string filterbyoperationids = context.ParseResult.GetValueForOption(FilterByOperationIdsOption);
string filterbytags = context.ParseResult.GetValueForOption(FilterByTagsOption);
string filterbycollection = context.ParseResult.GetValueForOption(FilterByCollectionOption);

CancellationToken cancellationToken = (CancellationToken)context.BindingContext.GetService(typeof(CancellationToken));

using var loggerFactory = Logger.ConfigureLogger(logLevel);
var logger = loggerFactory.CreateLogger<OpenApiService>();
try
{
await OpenApiService.TransformOpenApiDocument(openapi, csdl, csdlFilter, output, cleanOutput, version, format, terseOutput, settingsFile, logLevel, inlineLocal, inlineExternal, filterbyoperationids, filterbytags, filterbycollection, cancellationToken);
await OpenApiService.TransformOpenApiDocument(openapi, csdl, csdlFilter, output, cleanOutput, version, format, terseOutput, settingsFile, inlineLocal, inlineExternal, filterbyoperationids, filterbytags, filterbycollection, logger, cancellationToken);

return 0;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public async Task<int> InvokeAsync(InvocationContext context)
var logger = loggerFactory.CreateLogger<OpenApiService>();
try
{
await OpenApiService.ValidateOpenApiDocument(openapi, logLevel, cancellationToken);
await OpenApiService.ValidateOpenApiDocument(openapi, logger, cancellationToken);
return 0;
}
catch (Exception ex)
Expand Down
6 changes: 3 additions & 3 deletions src/Microsoft.OpenApi.Hidi/Microsoft.OpenApi.Hidi.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<PackageId>Microsoft.OpenApi.Hidi</PackageId>
<ToolCommandName>hidi</ToolCommandName>
<PackageOutputPath>./../../artifacts</PackageOutputPath>
<Version>1.1.0</Version>
<Version>1.2.0</Version>
<Description>OpenAPI.NET CLI tool for slicing OpenAPI documents</Description>
<Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
<PackageTags>OpenAPI .NET</PackageTags>
Expand All @@ -42,8 +42,8 @@
<PackageReference Include="Microsoft.Extensions.Logging.Console" Version="7.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="7.0.0" />
<PackageReference Include="System.CommandLine" Version="2.0.0-beta4.22272.1" />
<PackageReference Include="Microsoft.OData.Edm" Version="7.12.5" />
<PackageReference Include="Microsoft.OpenApi.OData" Version="1.2.0-preview8" />
<PackageReference Include="Microsoft.OData.Edm" Version="7.14.0" />
<PackageReference Include="Microsoft.OpenApi.OData" Version="1.2.0-preview9" />
<PackageReference Include="System.CommandLine.Hosting" Version="0.4.0-alpha.22272.1" />
</ItemGroup>

Expand Down
Loading