make IDiagnosticExtensions internal and fix namespace #2053
+15
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mus65
requested review from
irvinesunday,
darrelmiller,
gavinbarron,
millicentachieng,
MaggieKimani1,
andrueastman and
baywet
as code owners
|
@mus65 thanks for noticing this and for contributing the fix! |
MaggieKimani1
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume this was neither meant to be public nor meant to be in the global namespace. I noticed this when trying the latest preview because it conflicted with our own AddRange extension method.
This was introduced in #1245 and made public in 90dc7fc#diff-65294c3e990da88445c0036dfe9f8e7bcfb00675881d47c22fb3c6000c3b9d76R56 .