Skip to content

Conversation

baywet
Copy link
Member

@baywet baywet commented Feb 28, 2022

This PR pushes multiple improvements to the pipeline definition:

  • Swaps ms build and vstest tasks by dotnet cli, to prepare an eventual transition to an ubuntu agent (performance) and for clarity
  • Adds policheck, credscan, binskim, and antimalware scan tasks (compliance)
  • Adds a deploy stage to avoid relying on the older release management, and use the same approbation rules defined in the environment across projects.

One thing I haven't included is the "has the version been bumped test" because I think further changes should be done to this pipeline:

  • The deploy job should be splat into 3 jobs (deploy open API, deploy readers, deploy hidi) so each module can be deployed indenpendently from one another.
  • Before each of those jobs, should be a reflective "check-openapi/reader/hidi version has been bumped" job that'd fail in case this was forgotten.

https://microsoftgraph.visualstudio.com/Graph%20Developer%20Experiences/_build/results?buildId=68725&view=results

@baywet baywet self-assigned this Feb 28, 2022
@baywet baywet requested a review from MaggieKimani1 February 28, 2022 15:46
@baywet baywet force-pushed the feature/pipeline-upgrades branch from e6b9240 to 37e4856 Compare February 28, 2022 18:29
Copy link
Contributor

@MaggieKimani1 MaggieKimani1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why the poliCheck for tool step is failing?

@baywet baywet requested a review from MaggieKimani1 February 28, 2022 20:11
@baywet baywet force-pushed the feature/pipeline-upgrades branch from 703d24c to 0db1483 Compare March 1, 2022 13:13
@baywet
Copy link
Member Author

baywet commented Mar 1, 2022

@MaggieKimani1 policheck and the later binskim issues have been fixed (inexistant or wrong paths)

I've rebased my PR after #750 was merged.
I've also taken the code from your test azure pipeline (github release for hidi) as well as splat the deploy stage in 3 deploy jobs so we can release things independently.

@baywet
Copy link
Member Author

baywet commented Mar 1, 2022

@MaggieKimani1
Copy link
Contributor

@MaggieKimani1 policheck and the later binskim issues have been fixed (inexistant or wrong paths)

I've rebased my PR after #750 was merged. I've also taken the code from your test azure pipeline (github release for hidi) as well as splat the deploy stage in 3 deploy jobs so we can release things independently.

Thanks for taking my changes and adding them to this PR.

@baywet baywet requested a review from MaggieKimani1 March 1, 2022 18:41
@baywet
Copy link
Member Author

baywet commented Mar 1, 2022

@baywet baywet merged commit 082f0bd into vnext Mar 1, 2022
@baywet baywet deleted the feature/pipeline-upgrades branch March 1, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants