Bump up System.Commandline API to v2.0.0-beta4.22272.1 #959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieKimani1
requested review from
irvinesunday,
darrelmiller,
peombwa,
zengin,
baywet and
millicentachieng
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+61
to
+70
| catch (Exception ex) | ||
| { | ||
| #if DEBUG | ||
| logger.LogCritical(ex, ex.Message); | ||
| throw; // so debug tools go straight to the source of the exception when attached | ||
| #else | ||
| logger.LogCritical( ex.Message); | ||
| return 1; | ||
| #endif | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
Comment on lines
36
to
46
| catch (Exception ex) | ||
| { | ||
| #if DEBUG | ||
| logger.LogCritical(ex, ex.Message); | ||
| throw; // so debug tools go straight to the source of the exception when attached | ||
| #else | ||
| logger.LogCritical( ex.Message); | ||
| Environment.Exit(1); | ||
| return 1; | ||
| #endif | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
Comment on lines
215
to
+218
| catch (Exception ex) | ||
| { | ||
| #if DEBUG | ||
| logger.LogCritical(ex, ex.Message); | ||
| #else | ||
| logger.LogCritical(ex.Message); | ||
|
|
||
| #endif | ||
| return 1; | ||
| } | ||
| throw new InvalidOperationException($"Could not transform the document, reason: {ex.Message}", ex); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
baywet
requested changes
Aug 4, 2022
baywet
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #888
Should fix #900