Have CompletionEntryDetails source use a relative path #19917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| formatContext, | ||
| symbolName: getSymbolName(symbol, symbolOriginInfo, compilerOptions.target), | ||
| getCanonicalFileName: createGetCanonicalFileName(host.useCaseSensitiveFileNames ? host.useCaseSensitiveFileNames() : false), | ||
| getCanonicalFileName, |
There was a problem hiding this comment.
Is it possible to pass in the getCanonicalFileName instead of creating it all the time? services has already created one.
ghost
force-pushed
the
completionEntryDetails_source
branch
from
7c0f102 to
e7c461b
Compare
mhegazy
approved these changes
Nov 14, 2017
|
We will need to port this to release-2.6 |
ghost
pushed a commit
that referenced
this pull request
Nov 14, 2017
* Have CompletionEntryDetails source use a relative path * Use getCanonicalFileName from services Instead of creating a new one
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Nov 15, 2017
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19895