Skip to content

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #46998

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Dec 3, 2021
@jakebailey
Copy link
Member

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 6, 2021

Heya @jakebailey, I've started to run the tarball bundle task on this PR at da482c7. You can monitor the build here.

@jakebailey
Copy link
Member

This PR does fix #46988 (that the type printed is wrong), but appears to do the opposite of what people are expecting on #47043, as it continues to treat the const keyword as part of the type so the semantic token will still be incorrect.

Note that hovering in VS Code doesn't behave this way; the Playground appears to have a different behavior and allows hovering on const, whereas VS Code does not.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 6, 2021

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/115939/artifacts?artifactName=tgz&fileId=523E00CEE9FCBF1C58DD4D352627C3AF2169DE2CB895F20B94C4BB6DB492AFB502&fileName=/typescript-4.6.0-insiders.20211206.tgz"
    }
}

and then running npm install.


There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My commentary on the hover not being present wasn't correct; the hover does work on VS Code Insiders, and I've validated that this PR works there.

This seems to be perpendicular to #47043.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover on as const shows type const = /*unresolved*/ any in 4.5.2
3 participants