Ensure distributive constraints of restrictive instantiations of type parameters don't exist #47091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parameters dont exist
typescript-bot
added
Author: Team
For Milestone Bug
|
What is a "restrictive instantiation"? #46761 doesn't mention that term, and I've personally never heard of it. Is it some kind of internal implementation detail? |
|
It's definitely an implementation detail. It's part of how we check if no instantiation of one thing is assignable to another thing. |
RyanCavanaugh
approved these changes
Sep 27, 2022
|
@weswigham I'm going through all the ready-to-merge PRs, and this one is signed off. Is it worth bringing up to date and merging it for 5.1? |
|
All right, this is old and looks like it's obsolete, so I'm going to close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since restrictive instantiations replace type parameter constraints with
unknown, if we use them to calculate a distributive constraint, we produce very wrong results. So we try to see if we're looking at such an instantiation when calculating a distributive constraint now, and choose to not yield a constraint if that is the case.Fixes #46761