Skip to content

fix(52440): typeof ... === "undefined" check on mapped object member doesn't narrow correctly, for only some purposes #52456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix(52440): typeof ... === "undefined" check on mapped object member doesn't narrow correctly, for only some purposes #52456

merged 1 commit into from
Jan 30, 2023

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #52440

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 27, 2023
@RyanCavanaugh
Copy link
Member

This looks right but I don't want to get surprised

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the perf test suite on this PR at e09645c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at e09645c. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite on this PR at e09645c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite on this PR at e09645c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite (tsserver) on this PR at e09645c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at e09645c. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 27, 2023 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite (tsserver) on this PR at e09645c. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are the results of running the user test suite comparing main and refs/pull/52456/merge:

Everything looks good!

1 similar comment
@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are the results of running the user test suite comparing main and refs/pull/52456/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Heya @RyanCavanaugh, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are the results of running the top-repos suite comparing main and refs/pull/52456/merge:

Everything looks good!

1 similar comment
@typescript-bot
Copy link
Collaborator

@RyanCavanaugh Here are the results of running the top-repos suite comparing main and refs/pull/52456/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52456
Metric main 52456 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 359,843k (± 0.02%) 359,777k (± 0.01%) -66k (- 0.02%) 359,736k 359,878k
Parse Time 3.96s (± 0.65%) 3.93s (± 0.73%) -0.03s (- 0.84%) 3.89s 3.97s
Bind Time 1.17s (± 0.54%) 1.17s (± 0.35%) +0.00s (+ 0.14%) 1.17s 1.18s
Check Time 8.63s (± 0.32%) 8.62s (± 0.56%) -0.00s (- 0.06%) 8.56s 8.70s
Emit Time 7.59s (± 0.39%) 7.61s (± 0.51%) +0.02s (+ 0.20%) 7.54s 7.66s
Total Time 21.35s (± 0.19%) 21.33s (± 0.42%) -0.02s (- 0.09%) 21.24s 21.49s
Compiler-Unions - node (v18.10.0, x64)
Memory used 192,532k (± 0.07%) 192,413k (± 0.07%) -119k (- 0.06%) 192,210k 192,532k
Parse Time 1.64s (± 2.00%) 1.63s (± 1.72%) -0.01s (- 0.30%) 1.59s 1.66s
Bind Time 0.79s (± 0.52%) 0.79s (± 0.65%) +0.00s (+ 0.21%) 0.79s 0.80s
Check Time 9.61s (± 0.24%) 9.67s (± 0.50%) +0.06s (+ 0.59%) 9.63s 9.76s
Emit Time 2.88s (± 5.77%) 2.92s (± 5.11%) +0.04s (+ 1.51%) 2.80s 3.11s
Total Time 14.92s (± 1.16%) 15.02s (± 0.87%) +0.10s (+ 0.66%) 14.90s 15.19s
Monaco - node (v18.10.0, x64)
Memory used 343,964k (± 0.01%) 343,981k (± 0.01%) +17k (+ 0.00%) 343,952k 344,010k
Parse Time 2.95s (± 0.93%) 2.95s (± 0.94%) -0.00s (- 0.06%) 2.90s 2.97s
Bind Time 1.03s (± 1.29%) 1.03s (± 0.96%) -0.00s (- 0.32%) 1.02s 1.04s
Check Time 7.06s (± 0.53%) 7.07s (± 0.43%) +0.01s (+ 0.19%) 7.04s 7.12s
Emit Time 4.34s (± 0.83%) 4.33s (± 0.24%) -0.01s (- 0.23%) 4.32s 4.35s
Total Time 15.39s (± 0.37%) 15.39s (± 0.30%) +0.00s (+ 0.01%) 15.32s 15.44s
TFS - node (v18.10.0, x64)
Memory used 300,380k (± 0.01%) 300,371k (± 0.01%) -9k (- 0.00%) 300,339k 300,416k
Parse Time 2.25s (± 1.16%) 2.24s (± 1.56%) -0.01s (- 0.52%) 2.21s 2.29s
Bind Time 1.17s (± 1.08%) 1.17s (± 0.64%) -0.00s (- 0.14%) 1.16s 1.18s
Check Time 6.50s (± 0.50%) 6.53s (± 0.95%) +0.03s (+ 0.41%) 6.46s 6.62s
Emit Time 3.91s (± 0.44%) 3.93s (± 0.62%) +0.02s (+ 0.47%) 3.91s 3.97s
Total Time 13.84s (± 0.50%) 13.86s (± 0.52%) +0.03s (+ 0.20%) 13.74s 13.94s
material-ui - node (v18.10.0, x64)
Memory used 476,737k (± 0.00%) 476,796k (± 0.02%) +59k (+ 0.01%) 476,711k 476,920k
Parse Time 3.57s (± 0.23%) 3.56s (± 0.79%) -0.01s (- 0.19%) 3.51s 3.59s
Bind Time 0.96s (± 0.54%) 0.97s (± 0.42%) +0.01s (+ 0.52%) 0.96s 0.97s
Check Time 17.07s (± 0.66%) 17.04s (± 0.55%) -0.03s (- 0.20%) 16.91s 17.17s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 21.60s (± 0.51%) 21.56s (± 0.47%) -0.04s (- 0.16%) 21.43s 21.68s
xstate - node (v18.10.0, x64)
Memory used 548,679k (± 0.02%) 548,602k (± 0.01%) -77k (- 0.01%) 548,526k 548,694k
Parse Time 4.55s (± 0.38%) 4.56s (± 0.27%) +0.00s (+ 0.07%) 4.54s 4.57s
Bind Time 1.72s (± 1.04%) 1.71s (± 1.25%) -0.01s (- 0.48%) 1.69s 1.74s
Check Time 2.72s (± 0.99%) 2.72s (± 0.91%) +0.00s (+ 0.06%) 2.69s 2.75s
Emit Time 0.09s (± 5.95%) 0.08s (± 6.19%) 🟩-0.00s (- 3.85%) 0.08s 0.09s
Total Time 9.08s (± 0.27%) 9.08s (± 0.54%) +0.00s (+ 0.04%) 9.05s 9.16s
Angular - node (v16.17.1, x64)
Memory used 359,209k (± 0.00%) 359,219k (± 0.00%) +10k (+ 0.00%) 359,192k 359,242k
Parse Time 4.17s (± 0.13%) 4.17s (± 0.12%) -0.00s (- 0.04%) 4.17s 4.18s
Bind Time 1.22s (± 0.68%) 1.23s (± 0.99%) +0.00s (+ 0.14%) 1.21s 1.24s
Check Time 9.40s (± 0.42%) 9.41s (± 0.44%) +0.01s (+ 0.09%) 9.36s 9.47s
Emit Time 8.05s (± 0.29%) 8.04s (± 0.33%) -0.01s (- 0.10%) 8.01s 8.08s
Total Time 22.85s (± 0.17%) 22.85s (± 0.25%) -0.00s (- 0.01%) 22.77s 22.91s
Compiler-Unions - node (v16.17.1, x64)
Memory used 194,270k (± 0.03%) 194,240k (± 0.03%) -30k (- 0.02%) 194,172k 194,294k
Parse Time 1.81s (± 0.67%) 1.81s (± 0.49%) +0.00s (+ 0.18%) 1.80s 1.82s
Bind Time 0.84s (± 0.61%) 0.84s (± 1.06%) -0.00s (- 0.40%) 0.83s 0.85s
Check Time 10.38s (± 0.41%) 10.38s (± 0.74%) 0.00s ( 0.00%) 10.32s 10.53s
Emit Time 3.06s (± 0.67%) 3.06s (± 0.93%) -0.00s (- 0.11%) 3.02s 3.10s
Total Time 16.09s (± 0.35%) 16.09s (± 0.42%) -0.00s (- 0.01%) 16.02s 16.21s
Monaco - node (v16.17.1, x64)
Memory used 343,260k (± 0.01%) 343,257k (± 0.02%) -3k (- 0.00%) 343,212k 343,347k
Parse Time 3.18s (± 1.39%) 3.18s (± 1.25%) 0.00s ( 0.00%) 3.12s 3.23s
Bind Time 1.11s (± 0.68%) 1.11s (± 0.46%) +0.00s (+ 0.45%) 1.11s 1.12s
Check Time 7.71s (± 0.25%) 7.74s (± 0.28%) +0.02s (+ 0.30%) 7.71s 7.76s
Emit Time 4.52s (± 0.41%) 4.52s (± 0.60%) 0.00s ( 0.00%) 4.49s 4.56s
Total Time 16.52s (± 0.22%) 16.55s (± 0.41%) +0.03s (+ 0.16%) 16.49s 16.65s
TFS - node (v16.17.1, x64)
Memory used 299,763k (± 0.01%) 299,768k (± 0.01%) +5k (+ 0.00%) 299,734k 299,784k
Parse Time 2.47s (± 1.44%) 2.46s (± 0.88%) -0.00s (- 0.14%) 2.43s 2.49s
Bind Time 1.25s (± 0.60%) 1.25s (± 0.41%) +0.00s (+ 0.13%) 1.25s 1.26s
Check Time 7.17s (± 0.39%) 7.18s (± 0.70%) +0.02s (+ 0.23%) 7.13s 7.27s
Emit Time 4.21s (± 0.61%) 4.21s (± 0.58%) -0.01s (- 0.16%) 4.18s 4.24s
Total Time 15.10s (± 0.37%) 15.10s (± 0.28%) -0.00s (- 0.00%) 15.04s 15.15s
material-ui - node (v16.17.1, x64)
Memory used 476,072k (± 0.02%) 476,052k (± 0.01%) -20k (- 0.00%) 475,994k 476,142k
Parse Time 3.71s (± 0.28%) 3.72s (± 0.11%) +0.01s (+ 0.22%) 3.72s 3.73s
Bind Time 1.01s (± 0.51%) 1.02s (± 0.00%) +0.01s (+ 0.66%) 1.02s 1.02s
Check Time 18.18s (± 0.82%) 18.06s (± 0.10%) -0.12s (- 0.63%) 18.04s 18.08s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 22.91s (± 0.66%) 22.80s (± 0.07%) -0.11s (- 0.46%) 22.78s 22.82s
xstate - node (v16.17.1, x64)
Memory used 546,315k (± 0.02%) 546,384k (± 0.02%) +69k (+ 0.01%) 546,246k 546,499k
Parse Time 4.77s (± 0.59%) 4.75s (± 0.59%) -0.02s (- 0.31%) 4.71s 4.79s
Bind Time 1.82s (± 3.93%) 1.84s (± 0.77%) +0.02s (+ 1.38%) 1.82s 1.86s
Check Time 3.01s (± 2.87%) 2.97s (± 0.82%) -0.04s (- 1.28%) 2.94s 3.01s
Emit Time 0.09s (± 4.45%) 0.09s (± 5.53%) +0.00s (+ 1.82%) 0.09s 0.10s
Total Time 9.68s (± 0.47%) 9.65s (± 0.34%) -0.03s (- 0.31%) 9.60s 9.70s
Angular - node (v14.15.1, x64)
Memory used 352,844k (± 0.01%) 352,843k (± 0.01%) -1k (- 0.00%) 352,819k 352,875k
Parse Time 4.21s (± 0.41%) 4.25s (± 0.48%) +0.04s (+ 0.95%) 4.23s 4.28s
Bind Time 1.28s (± 0.32%) 1.28s (± 0.40%) +0.00s (+ 0.39%) 1.28s 1.29s
Check Time 9.75s (± 0.22%) 9.67s (± 0.56%) -0.08s (- 0.77%) 9.61s 9.76s
Emit Time 8.37s (± 0.58%) 8.40s (± 0.38%) +0.03s (+ 0.32%) 8.37s 8.44s
Total Time 23.61s (± 0.27%) 23.61s (± 0.32%) -0.00s (- 0.01%) 23.50s 23.71s
Compiler-Unions - node (v14.15.1, x64)
Memory used 189,683k (± 0.70%) 189,202k (± 0.07%) -481k (- 0.25%) 189,063k 189,395k
Parse Time 1.84s (± 0.66%) 1.86s (± 0.74%) +0.01s (+ 0.72%) 1.84s 1.88s
Bind Time 0.86s (± 0.60%) 0.87s (± 0.97%) +0.01s (+ 0.97%) 0.86s 0.88s
Check Time 10.42s (± 0.70%) 10.39s (± 0.75%) -0.03s (- 0.29%) 10.30s 10.51s
Emit Time 3.42s (± 3.85%) 3.39s (± 4.98%) -0.02s (- 0.68%) 3.15s 3.52s
Total Time 16.54s (± 0.72%) 16.51s (± 0.95%) -0.03s (- 0.20%) 16.26s 16.70s
Monaco - node (v14.15.1, x64)
Memory used 338,030k (± 0.00%) 338,032k (± 0.00%) +2k (+ 0.00%) 338,014k 338,055k
Parse Time 3.22s (± 0.66%) 3.23s (± 0.74%) +0.01s (+ 0.41%) 3.19s 3.25s
Bind Time 1.11s (± 0.68%) 1.11s (± 0.57%) +0.00s (+ 0.15%) 1.10s 1.12s
Check Time 8.05s (± 0.54%) 8.06s (± 0.67%) +0.01s (+ 0.17%) 7.97s 8.12s
Emit Time 4.74s (± 0.70%) 4.76s (± 0.36%) +0.02s (+ 0.49%) 4.73s 4.78s
Total Time 17.11s (± 0.38%) 17.17s (± 0.48%) +0.06s (+ 0.33%) 17.05s 17.24s
TFS - node (v14.15.1, x64)
Memory used 294,587k (± 0.01%) 294,604k (± 0.00%) +17k (+ 0.01%) 294,586k 294,621k
Parse Time 2.76s (± 0.44%) 2.75s (± 0.23%) -0.01s (- 0.18%) 2.74s 2.76s
Bind Time 1.10s (± 0.89%) 1.11s (± 0.76%) +0.00s (+ 0.30%) 1.09s 1.11s
Check Time 7.49s (± 0.25%) 7.51s (± 0.45%) +0.03s (+ 0.36%) 7.48s 7.55s
Emit Time 4.61s (± 0.63%) 4.61s (± 0.65%) +0.00s (+ 0.11%) 4.57s 4.65s
Total Time 15.95s (± 0.34%) 15.98s (± 0.36%) +0.02s (+ 0.15%) 15.90s 16.07s
material-ui - node (v14.15.1, x64)
Memory used 471,565k (± 0.00%) 471,563k (± 0.00%) -3k (- 0.00%) 471,547k 471,583k
Parse Time 3.94s (± 0.67%) 3.94s (± 0.57%) +0.01s (+ 0.17%) 3.92s 3.97s
Bind Time 1.04s (± 1.16%) 1.05s (± 0.49%) +0.00s (+ 0.32%) 1.04s 1.05s
Check Time 18.94s (± 0.11%) 19.07s (± 0.34%) +0.13s (+ 0.66%) 18.95s 19.13s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 23.92s (± 0.13%) 24.06s (± 0.30%) +0.13s (+ 0.56%) 23.93s 24.12s
xstate - node (v14.15.1, x64)
Memory used 534,481k (± 0.00%) 534,468k (± 0.01%) -13k (- 0.00%) 534,438k 534,507k
Parse Time 5.12s (± 0.69%) 5.16s (± 0.58%) +0.05s (+ 0.88%) 5.11s 5.19s
Bind Time 1.71s (± 0.44%) 1.71s (± 0.78%) +0.00s (+ 0.20%) 1.69s 1.73s
Check Time 3.10s (± 1.09%) 3.09s (± 0.67%) -0.01s (- 0.38%) 3.07s 3.13s
Emit Time 0.10s (± 0.00%) 0.10s (± 0.00%) 0.00s ( 0.00%) 0.10s 0.10s
Total Time 10.03s (± 0.67%) 10.07s (± 0.47%) +0.04s (+ 0.35%) 9.99s 10.12s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52456 6
Baseline main 6

TSServer

Comparison Report - main..52456
Metric main 52456 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,515ms (± 1.42%) 2,536ms (± 1.23%) +21ms (+ 0.82%) 2,479ms 2,570ms
Req 2 - geterr 5,504ms (± 0.41%) 5,497ms (± 0.77%) -7ms (- 0.12%) 5,449ms 5,548ms
Req 3 - references 363ms (± 0.73%) 365ms (± 0.73%) +2ms (+ 0.55%) 361ms 369ms
Req 4 - navto 285ms (± 0.29%) 284ms (± 0.48%) -0ms (- 0.12%) 283ms 287ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 68ms (± 5.11%) 66ms (± 1.24%) 🟩-3ms (- 3.67%) 64ms 66ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,713ms (± 0.98%) 2,713ms (± 0.63%) 0ms ( 0.00%) 2,696ms 2,736ms
Req 2 - geterr 4,055ms (± 0.42%) 4,055ms (± 0.46%) +1ms (+ 0.02%) 4,032ms 4,076ms
Req 3 - references 367ms (± 0.54%) 368ms (± 0.97%) +1ms (+ 0.36%) 365ms 375ms
Req 4 - navto 297ms (± 0.72%) 301ms (± 0.75%) +4ms (+ 1.24%) 298ms 304ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 80ms (± 7.93%) 82ms (± 0.50%) +2ms (+ 2.51%) 81ms 82ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,489ms (± 0.84%) 3,493ms (± 0.62%) +3ms (+ 0.10%) 3,472ms 3,532ms
Req 2 - geterr 1,415ms (± 1.01%) 1,414ms (± 0.63%) -1ms (- 0.06%) 1,404ms 1,425ms
Req 3 - references 104ms (± 1.99%) 104ms (± 1.66%) +0ms (+ 0.16%) 102ms 106ms
Req 4 - navto 357ms (± 1.84%) 356ms (± 0.35%) -1ms (- 0.23%) 354ms 357ms
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) 0 ( 0.00%) 3,175 3,175
Req 5 - completionInfo 471ms (± 0.94%) 468ms (± 1.50%) -3ms (- 0.53%) 459ms 476ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,783ms (± 0.25%) 2,772ms (± 0.60%) -12ms (- 0.43%) 2,748ms 2,795ms
Req 2 - geterr 5,881ms (± 0.49%) 5,875ms (± 0.34%) -6ms (- 0.09%) 5,852ms 5,901ms
Req 3 - references 376ms (± 1.63%) 377ms (± 1.23%) +1ms (+ 0.13%) 370ms 384ms
Req 4 - navto 277ms (± 0.66%) 278ms (± 0.81%) +1ms (+ 0.18%) 274ms 280ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 74ms (± 4.19%) 77ms (±10.22%) +3ms (+ 4.31%) 70ms 91ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,932ms (± 0.78%) 2,932ms (± 0.84%) -0ms (- 0.01%) 2,903ms 2,972ms
Req 2 - geterr 4,393ms (± 0.28%) 4,393ms (± 0.31%) -1ms (- 0.02%) 4,378ms 4,411ms
Req 3 - references 377ms (± 0.70%) 379ms (± 0.97%) +3ms (+ 0.66%) 374ms 383ms
Req 4 - navto 288ms (± 0.26%) 288ms (± 0.87%) -0ms (- 0.06%) 283ms 290ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 72ms (± 1.14%) 73ms (± 1.12%) +1ms (+ 1.40%) 72ms 74ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,631ms (± 0.44%) 3,632ms (± 0.23%) +2ms (+ 0.04%) 3,619ms 3,640ms
Req 2 - geterr 1,566ms (± 0.65%) 1,556ms (± 0.85%) -10ms (- 0.61%) 1,542ms 1,580ms
Req 3 - references 111ms (± 1.44%) 112ms (± 1.10%) +0ms (+ 0.30%) 110ms 113ms
Req 4 - navto 344ms (± 1.11%) 342ms (± 1.43%) -2ms (- 0.68%) 338ms 348ms
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) 0 ( 0.00%) 3,175 3,175
Req 5 - completionInfo 484ms (± 1.46%) 478ms (± 0.69%) -6ms (- 1.31%) 473ms 481ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,905ms (± 0.17%) 2,910ms (± 0.52%) +5ms (+ 0.16%) 2,886ms 2,926ms
Req 2 - geterr 6,249ms (± 0.73%) 6,284ms (± 0.68%) +35ms (+ 0.56%) 6,210ms 6,341ms
Req 3 - references 389ms (± 0.60%) 392ms (± 0.88%) +3ms (+ 0.73%) 386ms 396ms
Req 4 - navto 284ms (± 1.19%) 282ms (± 1.83%) -2ms (- 0.53%) 278ms 291ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 81ms (± 8.67%) 87ms (± 8.88%) +5ms (+ 6.35%) 73ms 92ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,091ms (± 0.79%) 3,086ms (± 1.02%) -6ms (- 0.18%) 3,054ms 3,139ms
Req 2 - geterr 4,687ms (± 0.13%) 4,705ms (± 0.37%) +17ms (+ 0.37%) 4,678ms 4,730ms
Req 3 - references 405ms (± 0.60%) 405ms (± 0.97%) +1ms (+ 0.16%) 403ms 413ms
Req 4 - navto 291ms (± 1.06%) 291ms (± 0.85%) -1ms (- 0.17%) 288ms 295ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 83ms (± 4.41%) 81ms (± 0.64%) -2ms (- 2.62%) 80ms 81ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,961ms (± 0.77%) 3,982ms (± 0.75%) +21ms (+ 0.52%) 3,947ms 4,018ms
Req 2 - geterr 1,503ms (± 0.91%) 1,535ms (± 1.79%) +33ms (+ 2.17%) 1,509ms 1,565ms
Req 3 - references 134ms (± 2.26%) 132ms (± 3.49%) -2ms (- 1.50%) 126ms 137ms
Req 4 - navto 375ms (± 0.89%) 374ms (± 0.36%) -0ms (- 0.09%) 373ms 377ms
Req 5 - completionInfo count 3,175 (± 0.00%) 3,175 (± 0.00%) 0 ( 0.00%) 3,175 3,175
Req 5 - completionInfo 510ms (± 1.99%) 502ms (± 2.71%) -7ms (- 1.44%) 483ms 515ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52456 6
Baseline main 6

Startup

Comparison Report - main..52456
Metric main 52456 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 142.20ms (± 0.18%) 142.96ms (± 0.35%) +0.75ms (+ 0.53%) 141.90ms 146.92ms
tsserver-startup - node (v16.17.1, x64)
Execution time 225.82ms (± 0.19%) 228.82ms (± 0.41%) +3.00ms (+ 1.33%) 224.84ms 233.65ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 228.34ms (± 0.23%) 231.57ms (± 0.33%) +3.23ms (+ 1.42%) 227.52ms 237.49ms
typescript-startup - node (v16.17.1, x64)
Execution time 209.31ms (± 0.17%) 212.20ms (± 0.36%) +2.89ms (+ 1.38%) 208.91ms 221.01ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52456 6
Baseline main 6

Developer Information:

Download Benchmark

@RyanCavanaugh RyanCavanaugh merged commit 3c0a3e5 into microsoft:main Jan 30, 2023
@RyanCavanaugh
Copy link
Member

Thanks!

@Andarist Andarist mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typeof ... === "undefined" check on mapped object member doesn't narrow correctly, for only some purposes
3 participants
@a-tarasyuk @RyanCavanaugh @typescript-bot