SSH reconnect requires password in background

[isidorn]

Refs: #1057

1. macOS, nightly SSH, "remote.SSH.enableDynamicForwarding": true
2. Connect to the VM provided in the testplan issue
3. Plug out your internet connection
4. Attempting to reconnect -> plug internet back in
5. You get a prompt for the password which is in the background. It is hard to spot and feels like a bad ux experience 🐛

The password prompt should be in front somehow, and the reconnect dialog should no longer be shown.

If I reconnect again I have to enter the password again. Not sure if this is expected.

SSH output log

[14:46:36.835] remote-ssh-nightly@2019.7.42088
[14:46:36.835] darwin x64
[14:46:36.836] SSH Resolver called for "ssh-remote+robvm", attempt 1
[14:46:36.836] SSH Resolver called for host: robvm
[14:46:36.836] Setting up SSH remote "robvm"
[14:46:36.849] Using commit id "cf03ea3729dc37e439d724267ad29dc5840f903a" and quality "insider" for server
[14:46:36.851] Testing ssh with ssh -V
[14:46:36.864] ssh exited with code: 0
[14:46:36.864] Got stderr from ssh: OpenSSH_7.9p1, LibreSSL 2.7.3
[14:46:36.865] Running script with connection command: ssh -D 50227 -o ConnectTimeout=15 robvm bash
[14:46:36.865] Install and start server if needed
[14:46:38.452] > roblou@52.247.215.15's password: 
[14:46:38.452] Got some output, clearing connection timeout
[14:46:40.487] "install" wrote data to terminal: "***************"
[14:46:40.491] > 
[14:46:41.896] > Running remote connection script
[14:46:41.900] > Acquiring lock on /home/roblou/.vscode-server-insiders/bin/cf03ea3729dc37e439d724267ad29dc5840f903a/vscode-remote-lock.cf03ea3729dc37e439d724267ad29dc5840f903a
[14:46:41.904] > Found old VS Code install e80dd4f217db6e230d311a87fdf4276f740f6445, attempting to clean up
[14:46:41.923] > Install still has running processes, not deleting: e80dd4f217db6e230d311a87fdf4276f740f6445
> Found old VS Code install c089daa858f34631f5f827ff8a0313bf1e2ded6d, attempting to clean up
[14:46:41.939] > Install still has running processes, not deleting: c089daa858f34631f5f827ff8a0313bf1e2ded6d
[14:46:41.941] > Found existing installation at /home/roblou/.vscode-server-insiders/bin/cf03ea3729dc37e439d724267ad29dc5840f903a...
[14:46:41.957] > Found running server...
>  
> *
> * Reminder: You may only use this software with Visual Studio family products,
> * as described in the license (https://go.microsoft.com/fwlink/?linkid=2077057)
> *
>  
[14:46:42.053] > Checking server status on port 43403 with wget
> f8c13071-12a9-4dcf-b3af-7a509eb5d30e==43403==33551==ubuntu==
[14:46:42.054] Received install output: f8c13071-12a9-4dcf-b3af-7a509eb5d30e==43403==33551==ubuntu==
[14:46:42.054] Remote server is listening on port 43403
[14:46:42.055] Starting forwarding server. localPort 50231 -> socksPort 50227 -> remotePort 43403
[14:46:42.055] Forwarding server listening on 50231
[14:46:42.055] Waiting for ssh tunnel to be ready
[14:46:42.056] [Forwarding server 50231] Got connection 0
[14:46:42.056] Tunneled remote port 43403 to local port 50231
[14:46:42.057] Resolved "ssh-remote+robvm" to "127.0.0.1:50231"
[14:46:42.057] TELEMETRY: {"eventName":"resolver","properties":{"outcome":"success","osReleaseId":"ubuntu"},"measures":{"resolveAttempts":1,"retries":1}}
[14:46:42.057] ------




[14:46:42.063] [Forwarding server 50231] Got connection 1
[14:46:42.064] [Forwarding server 50231] Got connection 2
[14:54:43.676] Starting forwarding server. localPort 11111 -> socksPort 50227 -> remotePort 11111
[14:54:43.676] Forwarding server listening on 11111
[14:54:43.676] Waiting for ssh tunnel to be ready
[14:54:43.678] [Forwarding server 11111] Got connection 0
[14:54:43.678] Tunneled remote port 11111 to local port 11111
[14:54:43.837] Failed to set up socket for dynamic port forward to remote port ${remotePort}: Socket closed. Is the remote port correct?
[14:54:43.837] > channel 3: open failed: connect failed: Connection refused
[14:54:46.842] [Forwarding server 11111] Got connection 1
[14:54:46.853] [Forwarding server 11111] Got connection 2
[14:54:47.001] Failed to set up socket for dynamic port forward to remote port ${remotePort}: Socket closed. Is the remote port correct?
[14:54:47.002] > channel 3: open failed: connect failed: Connection refused
[14:54:47.014] Failed to set up socket for dynamic port forward to remote port ${remotePort}: Socket closed. Is the remote port correct?
[14:54:47.016] > channel 6: open failed: connect failed: Connection refused
[14:55:24.319] SSH Resolver called for "ssh-remote+robvm", attempt 2
[14:55:24.319] SSH Resolver called for host: robvm
[14:55:24.319] Setting up SSH remote "robvm"
[14:55:24.320] Using commit id "cf03ea3729dc37e439d724267ad29dc5840f903a" and quality "insider" for server
[14:55:24.321] Running script with connection command: ssh -D 50383 -o ConnectTimeout=15 robvm bash
[14:55:24.322] Install and start server if needed
[14:55:24.356] > ssh: connect to host 52.247.215.15 port 22: Network is unreachable
[14:55:24.356] Got some output, clearing connection timeout
[14:55:24.845] "install" terminal command done
[14:55:24.845] Install terminal quit with output: ssh: connect to host 52.247.215.15 port 22: Network is unreachable
[14:55:24.845] Received install output: ssh: connect to host 52.247.215.15 port 22: Network is unreachable
[14:55:24.845] Network is unreachable
[14:55:24.845] TELEMETRY: {"eventName":"resolver","properties":{"outcome":"failure","reason":"OfflineError"},"measures":{"resolveAttempts":2,"retries":1}}
[14:55:24.846] ------




[14:55:29.851] SSH Resolver called for "ssh-remote+robvm", attempt 3
[14:55:29.851] SSH Resolver called for host: robvm
[14:55:29.851] Setting up SSH remote "robvm"
[14:55:29.852] Using commit id "cf03ea3729dc37e439d724267ad29dc5840f903a" and quality "insider" for server
[14:55:29.854] Running script with connection command: ssh -D 50407 -o ConnectTimeout=15 robvm bash
[14:55:29.854] Install and start server if needed
[14:55:31.406] > roblou@52.247.215.15's password: 
[14:55:31.406] Got some output, clearing connection timeout
[14:56:02.042] "install" wrote data to terminal: "***************"
[14:56:02.049] > 
[14:56:03.473] > Running remote connection script
[14:56:03.477] > Acquiring lock on /home/roblou/.vscode-server-insiders/bin/cf03ea3729dc37e439d724267ad29dc5840f903a/vscode-remote-lock.cf03ea3729dc37e439d724267ad29dc5840f903a
[14:56:03.482] > Found old VS Code install e80dd4f217db6e230d311a87fdf4276f740f6445, attempting to clean up
[14:56:03.503] > Install still has running processes, not deleting: e80dd4f217db6e230d311a87fdf4276f740f6445
> Found old VS Code install c089daa858f34631f5f827ff8a0313bf1e2ded6d, attempting to clean up
[14:56:03.504] > Failed to acquire lock for install, not deleting: c089daa858f34631f5f827ff8a0313bf1e2ded6d
[14:56:03.506] > Found existing installation at /home/roblou/.vscode-server-insiders/bin/cf03ea3729dc37e439d724267ad29dc5840f903a...
[14:56:03.525] > Found running server...
>  
> *
> * Reminder: You may only use this software with Visual Studio family products,
> * as described in the license (https://go.microsoft.com/fwlink/?linkid=2077057)
[14:56:03.631] > *
>  
> Checking server status on port 43403 with wget
> 785fa241-3ecb-481b-ae01-1db1fe65ae0e==43403==33551==ubuntu==
[14:56:03.631] Received install output: 785fa241-3ecb-481b-ae01-1db1fe65ae0e==43403==33551==ubuntu==
[14:56:03.632] Remote server is listening on port 43403
[14:56:03.632] Starting forwarding server. localPort 50434 -> socksPort 50407 -> remotePort 43403
[14:56:03.633] Forwarding server listening on 50434
[14:56:03.633] Waiting for ssh tunnel to be ready
[14:56:03.633] [Forwarding server 50434] Got connection 0
[14:56:03.633] Tunneled remote port 43403 to local port 50434
[14:56:03.634] Resolved "ssh-remote+robvm" to "127.0.0.1:50434"
[14:56:03.634] TELEMETRY: {"eventName":"resolver","properties":{"outcome":"success","osReleaseId":"ubuntu"},"measures":{"resolveAttempts":3,"retries":1}}
[14:56:03.634] ------




[14:56:03.645] [Forwarding server 50434] Got connection 1
[14:56:03.645] [Forwarding server 50434] Got connection 2

[roblourens]

I don't really know what to do about this :/

[isidorn]

fyi @alexandrudima

[alexdima]

fyi @sbatten --- Looks like there is a need for certain popups to come on top of the blocking modal popup.... :|

[sbatten]

perhaps we can force the blocking modal to relegate to the notification in this case as it does when the user clicks the Dismiss button

[roblourens]

I think that would make sense. It's possible that reconnecting fails after entering your password, and we go back into the "waiting" state. I think ideally we would show the overlay again after that but it's not necessary.

[sbatten]

microsoft/vscode@3a08a39