Remove System.IdentityModel.Tokens.Jwt dependency
#1862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peombwa
requested review from
ddyett,
shemogumbe and
timayabi2020
as code owners
| { | ||
| // Arrange | ||
| string accessToken = "ACCESS_TOKEN_VIA_DELEGATE_PROVIDER"; | ||
| string accessToken = "eyJhbGciOiJIUzI1NiJ9.eyJSb2xlIjoiVGVzdCIsIklzc3VlciI6Iklzc3VlciIsIlVzZXJuYW1lIjoiVGVzdCIsImV4cCI6MTY3ODQ4ODgxNiwiaWF0IjoxNjc4NDg4ODE2fQ.hpYypwHAV8H3jb4KuTiLpgLWy9A8H2d9HG7SxJ8Kpn0"; |
There was a problem hiding this comment.
@peombwa Why do we have a hard coded token?
There was a problem hiding this comment.
@timayabi2020, this is a dummy access token for running the test. Here is the jwt.ms output:
{
"alg": "HS256"
}.{
"Role": "Test",
"Issuer": "Issuer",
"Username": "Test",
"exp": 1678488816,
"iat": 1678488816
}.[Signature]
As part of this PR, Connect-MgGraph will now validate the structure of the JWT to determine if it can be decoded as per https://tools.ietf.org/html/rfc7519.
timayabi2020
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1816 by replacing
System.IdentityModel.Tokens.Jwtlibrary with an internal JWT decoder as per https://tools.ietf.org/html/rfc7519.