Skip to content

Conversation

freider
Copy link
Contributor

@freider freider commented Sep 8, 2025

This is prep for the addition of actual cbor support in the client (see #3474 which is being reworked now to use this information)

  • Adds proto fields supported_input_formats and supported_output_formats
  • Propagate/set these correctly for existing functions and methods (disambiguating asgi and pickle at the moment)
  • Adds DATA_FORMAT_CBOR, without actually implementing it in this PR (see Cbor2 serialization for function calling [SDK-584] #3474)

Compatibility checklist

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Release checklist

If you intend for this commit to trigger a full release to PyPI, please ensure that the following steps have been taken:

  • Version file (modal_version/__init__.py) has been updated with the next logical version
  • Changelog has been cleaned up and given an appropriate subhead

Changelog

@freider freider force-pushed the freider/advertise-cbor-compatibility branch from dfdb077 to 0d77485 Compare September 12, 2025 08:58
@freider freider changed the base branch from freider/cbor2-function-calling to main September 12, 2025 08:58
@freider freider changed the title Advertise cbor compatibility in Function metadata [cbor support] Adds output_format and supported_data_formats to Function metadata Sep 12, 2025
@freider freider requested a review from mwaskom September 12, 2025 11:15
@freider freider changed the title [cbor support] Adds output_format and supported_data_formats to Function metadata [cbor support] Adds supported_output_formats and supported_data_formats to Function metadata Sep 16, 2025
@freider freider changed the title [cbor support] Adds supported_output_formats and supported_data_formats to Function metadata [cbor support] Adds supported_output_formats and supported_input_formats to Function metadata Sep 16, 2025
@freider
Copy link
Contributor Author

freider commented Sep 18, 2025

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @mwaskom will follow-up review this.

@freider freider merged commit 00683ae into main Sep 18, 2025
27 checks passed
@freider freider deleted the freider/advertise-cbor-compatibility branch September 18, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants