Skip to content

Changed the name of the ActivitySource and Metric to clarify that the semantic conventions have not been ratified yet. #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025
Merged

Changed the name of the ActivitySource and Metric to clarify that the semantic conventions have not been ratified yet. #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d5bb15
Changed the name of the ActivitySource and Metric to clarify that the…
Apr 2, 2025
fd6d684
Merge branch 'main' into main
samsp-msft Apr 2, 2025
d67cc4c
Update src/ModelContextProtocol/Diagnostics.cs
stephentoub Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ModelContextProtocol/Diagnostics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace ModelContextProtocol;

internal static class Diagnostics
{
internal static ActivitySource ActivitySource { get; } = new("ModelContextProtocol");
internal static ActivitySource ActivitySource { get; } = new("Experimental.ModelContextProtocol");

/// <summary>
/// Follows boundaries from http.server.request.duration/http.client.request.duration
Expand All @@ -24,6 +24,6 @@ internal static class Diagnostics
HistogramBucketBoundaries = [0.01, 0.02, 0.05, 0.1, 0.2, 0.5, 1, 2, 5, 10, 30, 60, 120, 300],
};

internal static Meter Meter { get; } = new("ModelContextProtocol");
internal static Meter Meter { get; } = new("Experimental.ModelContextProtocol");

}
2 changes: 1 addition & 1 deletion tests/ModelContextProtocol.Tests/DiagnosticTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public async Task Session_TracksActivities()
var activities = new List<Activity>();

using (var tracerProvider = OpenTelemetry.Sdk.CreateTracerProviderBuilder()
.AddSource("ModelContextProtocol")
.AddSource("Experimental.ModelContextProtocol")
.AddInMemoryExporter(activities)
.Build())
{
Expand Down