Remove batching support from StreamableHttpServerTransport #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
approved these changes
May 1, 2025
Sounds good, either in this PR or a follow-up. Thanks! We should also consider having ctors on StreamServer/ClientTransport, accepting a single duplex Stream rather than one for each direction, but that can also be a separate thing. |
This was referenced Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I closed #158 which was our issue tracking support for JSON-RPC batching because the requirement has been removed from the draft specification as of modelcontextprotocol/modelcontextprotocol#416, and the feature didn't seem particularly useful. The SDK never sent batched messages.
I removed the batching support from the client in my Streamable HTTP client PR (#356), and this follows up to do the same thing for the server.
@stephentoub We could now more conveniently update the StreamableHttpServerTransport.HandlePostRequest(IDuplexPipe httpBodies, CancellationToken cancellationToken) method to take a duplex Stream instead of an IDuplexPipe without introducing extra copying if you also want to do that as part of this change.