Skip to content

Enhance HTTP and MCP session logging #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 8, 2025
+8 −0
Merged

Enhance HTTP and MCP session logging #608

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a15163d
add debug log for McpSession
theojiang25 Jul 10, 2025
64761d0
add request header logging at trace level
theojiang25 Jul 10, 2025
c5d7009
Revert "add request header logging at trace level"
theojiang25 Jul 10, 2025
adbec9a
remove session connected log and move to trace level
theojiang25 Jul 10, 2025
21ab803
Merge branch 'main' into theojiang/logging
theojiang25 Jul 10, 2025
ed0afc2
Merge branch 'main' into theojiang/logging
halter73 Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/ModelContextProtocol.Core/McpSession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ public McpSession(
_requestHandlers = requestHandlers;
_notificationHandlers = notificationHandlers;
_logger = logger ?? NullLogger.Instance;
LogSessionCreated(EndpointName, _sessionId, _transportKind);
}

/// <summary>
Expand Down Expand Up @@ -701,6 +702,7 @@ public void Dispose()
}

_pendingRequests.Clear();
LogSessionDisposed(EndpointName, _sessionId, _transportKind);
}

#if !NET
Expand Down Expand Up @@ -783,4 +785,10 @@ private static TimeSpan GetElapsed(long startingTimestamp) =>

[LoggerMessage(Level = LogLevel.Trace, Message = "{EndpointName} sending message. Message: '{Message}'.")]
private partial void LogSendingMessageSensitive(string endpointName, string message);

[LoggerMessage(Level = LogLevel.Trace, Message = "{EndpointName} session {SessionId} created with transport {TransportKind}")]
private partial void LogSessionCreated(string endpointName, string sessionId, string transportKind);

[LoggerMessage(Level = LogLevel.Trace, Message = "{EndpointName} session {SessionId} disposed with transport {TransportKind}")]
private partial void LogSessionDisposed(string endpointName, string sessionId, string transportKind);
}
Loading