-
Notifications
You must be signed in to change notification settings - Fork 516
Add conceptual docs on accessing HttpContext #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive documentation and sample code demonstrating how to access HttpContext from MCP tool call handlers when using the HTTP transport. The documentation includes explanations of using IHttpContextAccessor, code snippets, and working examples.
Key changes:
- Adds new HttpContext concept documentation with examples
- Creates sample project showing HttpContext access patterns in tool handlers
- Updates project files to disable assembly info generation across samples
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
docs/concepts/toc.yml | Adds HTTP Context section to documentation table of contents |
docs/concepts/httpcontext/httpcontext.md | Main documentation explaining HttpContext access patterns |
docs/concepts/httpcontext/samples/ | Complete sample project demonstrating HttpContext usage |
Multiple .csproj files | Adds assembly info generation settings to maintain consistency |
ModelContextProtocol.slnx | Includes new HttpContext sample project in solution |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
{ | ||
private readonly IHttpContextAccessor _httpContextAccessor; | ||
|
||
public ContextTools(IHttpContextAccessor httpContextAccessor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider expressing this as a primary constructor for brevity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would allow unifying the two snippets into one for a self-contained tool definition.
|
||
[McpServerTool(UseStructuredContent = true)] | ||
[Description("Retrieves the request information from the current HTTP context and returns it as structured content.")] | ||
public object GetRequestInfo() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we delete the tools not being used by the documentation?
This PR adds docs and sample to describe how to access the HttpContext for a request from a tool call handler.