Fix NPM package validation for scoped packages #429
Merged
+26
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domdomegg
force-pushed
the
adamj/fix-npm-scoped-packages
branch
from
60f5524 to
736901d
Compare
|
@domdomegg - #424 just added the extra validation to fail fast before we send a request. To clarify, it wasn't the fix for the URL encoding issue that we saw. Do we want to remove this validation? |
|
Sorry I have no idea what happened here! I didn't mean to remove this validation at all. I thought I had a PR up to URL encode the params, but think I mangled it in a force push... fixing... |
domdomegg
force-pushed
the
adamj/fix-npm-scoped-packages
branch
from
736901d to
17eb56d
Compare
- Add URL encoding for package identifiers and versions in NPM registry requests - Fixes issue where scoped packages like @hellocoop/admin-mcp failed validation - Add unit tests for scoped NPM packages Fixes #409 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> :house: Remote-Dev: homespace
|
Okay, correct implementation restored. @Avish34 would you be able to review this now corrected PR? |
|
No worries. |
rdimitrov
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #409