Skip to content

Conversation

H2CO3
Copy link

@H2CO3 H2CO3 commented Jul 27, 2018

  • remove several unnecessary allocations: clone()/to_owned()/to_string())
  • remove ref-deref noops for Copy types
  • #[derive] some useful std traits for certain types for better interoperability
  • replace write!(formatter, "string literal") with write_str()
  • remove redundant uses of .iter() in for loops over &T: IntoIterator<&T::Item>

…wned()`/`to_string()`) and ref-deref noops for `Copy` types; `#[derive]` some useful std traits for certain types for better interoperability; replace `write!(formatter, "string literal")` with `write_str()`
@zonyitoo
Copy link
Contributor

Good. Thanks.

@zonyitoo zonyitoo merged commit 463cdc1 into mongodb:master Jul 27, 2018
@H2CO3 H2CO3 deleted the grand-cleanup branch July 27, 2018 16:54
@H2CO3 H2CO3 restored the grand-cleanup branch July 28, 2018 05:32
@H2CO3 H2CO3 deleted the grand-cleanup branch July 28, 2018 05:43
lrlna pushed a commit to lrlna/bson-rs that referenced this pull request Feb 27, 2019
…wned()`/`to_string()`) and ref-deref noops for `Copy` types; `#[derive]` some useful std traits for certain types for better interoperability; replace `write!(formatter, "string literal")` with `write_str()` (mongodb#100)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants