RUST-2239 Fix performance of bson 3.0 #596
Merged
+118
−46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-2239
This takes 3.0 benchmark performance from a 0-90% regression, depending on the benchmark, to a 0-50% improvement 😁
All of the delta is in converting a
Document
into bytes; the improvement is from (a) encoding everything into a single running buffer rather than letting subdocuments allocate their own and (b) avoiding copies when encoding individual elements.Benchmark results from 2.15.x:
Benchmark results from 3.0 before this PR:
Benchmark results from 3.0 after this PR: