fix(NODE-7138): prevent duplicate metadata from being appended to handshake metadata #4651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariakp
added
Primary Review
dariakp
requested changes
Sep 10, 2025
baileympearson
force-pushed
the
NODE-7138
branch
from
9bce759 to
bd042de
Compare
dariakp
requested changes
Sep 11, 2025
test/integration/mongodb-handshake/mongodb-handshake.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/mongodb-handshake/mongodb-handshake.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/mongodb-handshake/mongodb-handshake.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/mongodb-handshake/mongodb-handshake.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/mongodb-handshake/mongodb-handshake.prose.test.ts
Outdated
Show resolved
Hide resolved
dariakp
requested changes
Sep 15, 2025
dariakp
requested changes
Sep 15, 2025
dariakp
added
Team Review
dariakp
previously requested changes
Sep 16, 2025
baileympearson
force-pushed
the
NODE-7138
branch
from
d22889d to
6632130
Compare
dariakp
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This PR is a POC implementation for mongodb/specifications#1833.
Additionally, while working on the implementation, I decided to simplify the handshake metadata logic by using
MongoClient.appendMetadata()to append the driverInfo provided to the MongoClient, if any was provided.Release Highlight
MongoClient.appendMetadata()ignores duplicate metadataMongoClient.appendMetadata()will no longer append metadata if it duplicates the metadata already appended to the MongoClient.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript