Skip to content

Conversation

durran
Copy link
Member

@durran durran commented Sep 15, 2025

Description

Requires @aws-sdk/credential-providers in order to perform AWS authentication.

Summary of Changes

  • Removes our implementation of AWS credential fetching.
  • Updates AWS tests.

What is the motivation for this change?

NODE-6988

Release Highlight

@aws-sdk/credential-providers is now required for MONGODB-AWS authentication

Previous versions of the driver contained two implementations for AWS authentication and could run the risk of the custom driver implementation not supporting all AWS authentication features as well as not being correct when AWS makes changes. Using the official AWS SDK in all cases alleviates these issues.

npm install @aws-sdk/credential-providers

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran changed the title feat(NODE-6988): require aws sdk for aws auth feat(NODE-6988)!: require aws sdk for aws auth Sep 15, 2025
@durran durran marked this pull request as ready for review September 17, 2025 15:06
@durran durran requested a review from a team as a code owner September 17, 2025 15:06
@baileympearson baileympearson self-assigned this Sep 17, 2025
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo code deletion! Just a few small comments.

@dariakp
Copy link
Contributor

dariakp commented Sep 18, 2025

@durran Can we add additional context in the release highlight to explain how the change benefits our users?

@durran
Copy link
Member Author

durran commented Sep 18, 2025

@durran Can we add additional context in the release highlight to explain how the change benefits our users?

@dariakp Updated.

@baileympearson baileympearson merged commit b7c6750 into main Sep 18, 2025
31 checks passed
@baileympearson baileympearson deleted the NODE-6988 branch September 18, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants