[api-minor] Use an icc profile for converting CMYK to RGB #19620

calixteman · 2025-03-06T18:13:13Z

No description provided.

calixteman · 2025-03-06T18:13:28Z

/botio browsertest

moz-tools-bot · 2025-03-06T18:13:30Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d2ec068ec8bd11c/output.txt

moz-tools-bot · 2025-03-06T18:13:30Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2281f91f2eb8adf/output.txt

moz-tools-bot · 2025-03-06T18:30:27Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d2ec068ec8bd11c/output.txt

Total script time: 16.93 mins

Regression tests: Passed

moz-tools-bot · 2025-03-06T18:45:04Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/2281f91f2eb8adf/output.txt

Total script time: 31.55 mins

Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/2281f91f2eb8adf/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2025-03-06T22:05:13Z

I'd expect lots of small movement all over the ref-tests with this patch, but I'd guess the explanation is that you forgot to add iccUrl in the https://github.com/mozilla/pdf.js/blob/master/test/driver.js file?

calixteman · 2025-03-06T22:06:31Z

I'd expect lots of small movement all over the ref-tests with this patch, but I'd guess the explanation is that you forgot to add iccUrl in the https://github.com/mozilla/pdf.js/blob/master/test/driver.js file?

Yep I was expecting the same and found this oblivion almost 5 minutes ago :)

Snuffleupagus

Leaving a couple of quick comments, especially the CmykICCBasedCS.prototype.name field is something that I cannot tell at a glance if it's correct.

external/iccs/LICENSE

gulpfile.mjs

src/core/colorspace_utils.js

src/display/api.js

src/core/icc_colorspace.js

calixteman · 2025-03-07T14:15:30Z

/botio browsertest

moz-tools-bot · 2025-03-07T14:15:33Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5461d40cdcdf2ec/output.txt

moz-tools-bot · 2025-03-07T14:15:34Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/553823d17b97a77/output.txt

moz-tools-bot · 2025-03-07T14:32:53Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/5461d40cdcdf2ec/output.txt

Total script time: 17.33 mins

Regression tests: FAILED

  different ref/snapshot: 304

Image differences available at: http://54.241.84.105:8877/5461d40cdcdf2ec/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2025-03-07T14:45:37Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/553823d17b97a77/output.txt

Total script time: 30.04 mins

Regression tests: FAILED

  different ref/snapshot: 305

Image differences available at: http://54.193.163.58:8877/553823d17b97a77/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2025-03-08T21:05:14Z

/botio-linux preview

moz-tools-bot · 2025-03-08T21:05:17Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2790a5ff086c6ee/output.txt

moz-tools-bot · 2025-03-08T21:06:11Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/2790a5ff086c6ee/output.txt

Total script time: 0.89 mins

Published

Viewer: http://54.241.84.105:8877/2790a5ff086c6ee/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/2790a5ff086c6ee/legacy/web/viewer.html

Snuffleupagus

While there's a bunch of movement in the ref-tests, this looks like an overall improvement when comparing with the rendering in Adobe Reader.

r=me, thank you.

src/core/jpg.js

calixteman · 2025-03-10T13:45:47Z

/botio browsertest

moz-tools-bot · 2025-03-10T13:45:50Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5a5df7f94586ee0/output.txt

moz-tools-bot · 2025-03-10T14:03:04Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/5a5df7f94586ee0/output.txt

Total script time: 17.23 mins

Regression tests: FAILED

  different ref/snapshot: 304

Image differences available at: http://54.241.84.105:8877/5a5df7f94586ee0/reftest-analyzer.html#web=eq.log

calixteman · 2025-03-10T15:55:59Z

/botio makeref

moz-tools-bot · 2025-03-10T15:56:01Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8d3d87f206b3f37/output.txt

moz-tools-bot · 2025-03-10T15:56:01Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/96f1a1b4e1b69f5/output.txt

moz-tools-bot · 2025-03-10T16:13:03Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/8d3d87f206b3f37/output.txt

Total script time: 17.02 mins

Make references: Passed
Check references: Passed

moz-tools-bot · 2025-03-10T16:40:10Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/96f1a1b4e1b69f5/output.txt

Total script time: 29.90 mins

Make references: Passed
Check references: Passed

Snuffleupagus reviewed Mar 7, 2025

View reviewed changes

Snuffleupagus added core image-quality labels Mar 7, 2025

calixteman force-pushed the cmyk_icc branch from 6d3d710 to 76f0d30 Compare March 7, 2025 14:11

Snuffleupagus added the release-blocker Blocker for the upcoming release label Mar 7, 2025

Snuffleupagus linked an issue Mar 8, 2025 that may be closed by this pull request

Broken PDF: Valve employee handbook #2218

Closed

calixteman marked this pull request as ready for review March 10, 2025 09:16

Snuffleupagus changed the title ~~Use an icc profile for converting CMYK to RGB~~ [api-minor] Use an icc profile for converting CMYK to RGB Mar 10, 2025

Snuffleupagus approved these changes Mar 10, 2025

View reviewed changes

src/core/jpg.js Outdated Show resolved Hide resolved

[api-minor] Use an icc profile for converting CMYK to RGB

7280540

calixteman force-pushed the cmyk_icc branch from 76f0d30 to 7280540 Compare March 10, 2025 13:30

calixteman merged commit 13474ac into mozilla:master Mar 10, 2025
9 checks passed

Snuffleupagus mentioned this pull request Mar 10, 2025

Version 5 release checklist #19536

Closed

4 tasks

Snuffleupagus mentioned this pull request Mar 17, 2025

[Bug]: JPEG images with CMYK-data broken when WebAssembly is disabled #19676

Closed

Snuffleupagus mentioned this pull request May 14, 2025

Use ImageDecoder to decode cmyk jpeg images (bug 1965870) #19918

Open

[api-minor] Use an icc profile for converting CMYK to RGB #19620

[api-minor] Use an icc profile for converting CMYK to RGB #19620

Uh oh!

Conversation

calixteman commented Mar 6, 2025

Uh oh!

calixteman commented Mar 6, 2025

Uh oh!

moz-tools-bot commented Mar 6, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Mar 6, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Mar 6, 2025

From: Bot.io (Linux m4)

Success

Uh oh!

moz-tools-bot commented Mar 6, 2025

From: Bot.io (Windows)

Failed

Uh oh!

Snuffleupagus commented Mar 6, 2025

Uh oh!

calixteman commented Mar 6, 2025

Uh oh!

Snuffleupagus left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

calixteman commented Mar 7, 2025

Uh oh!

moz-tools-bot commented Mar 7, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Mar 7, 2025

From: Bot.io (Windows)

Received

Uh oh!

moz-tools-bot commented Mar 7, 2025

From: Bot.io (Linux m4)

Failed

Uh oh!

moz-tools-bot commented Mar 7, 2025

From: Bot.io (Windows)

Failed

Uh oh!

Snuffleupagus commented Mar 8, 2025

Uh oh!

moz-tools-bot commented Mar 8, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Mar 8, 2025

From: Bot.io (Linux m4)

Success

Published

Uh oh!

Snuffleupagus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

calixteman commented Mar 10, 2025

Uh oh!

moz-tools-bot commented Mar 10, 2025

From: Bot.io (Linux m4)

Received

Uh oh!

moz-tools-bot commented Mar 10, 2025

From: Bot.io (Linux m4)

Failed

Snuffleupagus left a comment •

edited

Loading