[Editor] Pointer type initialization only when the user changes the mode #20226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be closed after PR #20213 |
legraina
commented
Sep 3, 2025
Comment on lines
+1880
to
+1881
| * @param {boolean} [isFromEvent] - true if the mode change is due to an event | ||
| * (e.g. toolbar button clicked). |
There was a problem hiding this comment.
Should it be isFromUser or isFromAction ?
4 tasks
legraina
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It clears the pointer type of
CurrentPointersoutside of theDrawingEditorto always keep the same, until the user changes the mode.One of the goal is to keep the same pointer type in case of a refresh of the page or if the user changes the pdf document.