Skip to content

Conversation

shotamatsuda
Copy link
Contributor

Description

This PR fixes that PassMultipleTextureNode and ReflectorNode losing their offsetNode when being cloned.

Copy link

github-actions bot commented Sep 8, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.24
79.14
338.24
79.14
+0 B
+0 B
WebGPU 579.64
160.17
579.7
160.18
+58 B
+9 B
WebGPU Nodes 578.25
159.93
578.31
159.94
+58 B
+9 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 469.83
113.84
469.83
113.84
+0 B
+0 B
WebGPU 649.34
175.82
649.37
175.83
+29 B
+8 B
WebGPU Nodes 603.45
164.99
603.48
165
+29 B
+8 B

@shotamatsuda shotamatsuda marked this pull request as ready for review September 8, 2025 02:00
@Mugen87 Mugen87 added this to the r181 milestone Sep 8, 2025
@Mugen87 Mugen87 merged commit 3d9a8c9 into mrdoob:dev Sep 9, 2025
9 checks passed
@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 9, 2025

I think the fix is simple/understandable enough that we can directly merge it 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants