[code-infra] Migrate error code extraction to code-infra #2670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brijeshb42
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
brijeshb42
added
the
scope: code-infra
brijeshb42
commented
Sep 5, 2025
| @@ -125,7 +125,7 @@ export const createSelector = (( | |||
| } else if (a) { | |||
| selector = a; | |||
| } else { | |||
| throw new Error('Missing arguments'); | |||
| throw /* minify-error-disabled */ new Error('Missing arguments'); | |||
There was a problem hiding this comment.
Doesn't really save that much.
commit: |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
brijeshb42
commented
Sep 5, 2025
| @@ -206,7 +206,7 @@ export const createSelectorMemoized: CreateSelectorFunction = (...selectors: any | |||
| case 2: return fn(state, a1, a2); | |||
| case 3: return fn(state, a1, a2, a3); | |||
| default: | |||
| throw new Error('unreachable'); | |||
| throw /* minify-error-disabled */ new Error('unreachable'); | |||
| * ... | ||
| */ | ||
| export default function formatErrorMessage(code: number, ...args: string[]): string { | ||
| const url = new URL(`https://base-ui.com/production-error/${code}`); |
There was a problem hiding this comment.
Implemented here #1463
There was a problem hiding this comment.
It can be this or https://base-ui.com/production-error?code=${code}
| if (process.env.NODE_ENV !== 'production') { | ||
| throw new Error('Base UI: Cannot call an event handler while rendering.'); | ||
| } | ||
| throw new Error('Base UI: Cannot call an event handler while rendering.'); |
There was a problem hiding this comment.
NODE_ENV check not needed now with extraction enabled.
brijeshb42
force-pushed
the
error-code-extraction
branch
from
1516364 to
10cb971
Compare
Bundle size report
|
brijeshb42
force-pushed
the
error-code-extraction
branch
5 times, most recently
from
d936046 to
2dbc69c
Compare
oliviertassinari
changed the title
brijeshb42
force-pushed
the
error-code-extraction
branch
3 times, most recently
from
604f17f to
3e1029c
Compare
github-actions
bot
added
the
PR: out-of-date
brijeshb42
force-pushed
the
error-code-extraction
branch
from
3e1029c to
4a7124d
Compare
github-actions
bot
added
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also migrated
markdownlintconfig to import fromcode-infra.