Skip to content

[select] Refactor index tracking #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[select] Refactor index tracking #2684

wants to merge 1 commit into from

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Sep 8, 2025

This more closesly matches Combobox's item index tracking to be less confusing.
Also refactors away useSelectRoot.

@atomiks atomiks added scope: select Changes related to the select. internal Behind-the-scenes enhancement. Formerly called “core”. labels Sep 8, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 8, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/react@2684

pnpm add https://pkg.pr.new/mui/base-ui/@base-ui-components/utils@2684

commit: 88e9c21

@netlify Netlify
Copy link

netlify bot commented Sep 8, 2025

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 88e9c21
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/68be66782801ad0008614156
😎 Deploy Preview https://deploy-preview-2684--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite will be requested when the pull request is marked ready for review colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak will be requested when the pull request is marked ready for review michaldudak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
internal Behind-the-scenes enhancement. Formerly called “core”. PR: out-of-date The pull request has merge conflicts and can't be merged. scope: select Changes related to the select.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@atomiks