Skip to content

[docs][autocomplete] Fix Google Maps demo #46793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2025
Merged

[docs][autocomplete] Fix Google Maps demo #46793

merged 1 commit into from
Aug 23, 2025

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 20, 2025 •
edited
Loading

It crashes with this error:

Invalid JSONP callback name: 'google_callback.«Rmlacjad9qmll6»'; only alphabet, number, '', '$', '.', '[' and ']' are allowed.

Why? Because facebook/react#32001

Before: https://mui.com/material-ui/react-autocomplete/#google-maps-place
After: https://deploy-preview-46793--material-ui.netlify.app/material-ui/react-autocomplete/#google-maps-place

@oliviertassinari oliviertassinari added scope: autocomplete Changes related to the autocomplete. This includes ComboBox. type: regression A bug, but worse, it used to behave as expected. docs Improvements or additions to the documentation. labels Aug 20, 2025
@mui-bot
Copy link

mui-bot commented Aug 20, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-46793--material-ui.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against b2cad96

@oliviertassinari oliviertassinari force-pushed the fix-autocomplete-google-maps-demo branch from cf76862 to b2cad96 Compare August 20, 2025 23:58
@zannager zannager requested a review from mj12albert August 21, 2025 09:23
@ZeeshanTamboli
Copy link
Member

@oliviertassinari How did you reproduce the error? I don't see any errors in Console tab or Network Tab in Chrome.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 21, 2025 •
edited
Loading

I get this:

SCR-20250821-ssle

https://mui.com/material-ui/react-autocomplete/#google-maps-place

ZeeshanTamboli
ZeeshanTamboli approved these changes Aug 23, 2025
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the error now. Looks good!

@ZeeshanTamboli ZeeshanTamboli changed the title [autocomplete] Fix Google Maps demo [docs][autocomplete] Fix Google Maps demo Aug 23, 2025
@oliviertassinari oliviertassinari merged commit 9870c9a into mui:master Aug 23, 2025
22 checks passed
@oliviertassinari oliviertassinari deleted the fix-autocomplete-google-maps-demo branch August 23, 2025 09:50
@oliviertassinari oliviertassinari mentioned this pull request Aug 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@mj12albert mj12albert Awaiting requested review from mj12albert

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation. scope: autocomplete Changes related to the autocomplete. This includes ComboBox. type: regression A bug, but worse, it used to behave as expected.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliviertassinari @mui-bot @ZeeshanTamboli