Skip to content

Conversation

XiaoMigros
Copy link
Contributor

Resolves: #18941

This PR introduces style settings for drawing barlines in front of key signatures and time signatures: Either to always use single barlines, always use double barlines, or to use double barlines in front of a system change. The default settings haven't been changed so the behavior is the same.

image

@its-not-nice
Copy link
Contributor

its-not-nice commented Jan 24, 2024

It might make sense to put these new options in the new 'Clefs, key & time signatures' section now that #20911 has been merged.

I'd envisaged the option being expressed something like "Double barline before key|time signatures" with options "Never"/"Always"/"At end of system only". In particular, the "Single barline" option is a bit misleading as it really means "don't change the preceding barline" (which could be anything).

There is also a question about cautionaries. Currently, double barlines will be drawn where the relevant "At end of system" option is chosen only if a cautionary is shown there; if you turn "Show cautionary" off, a single barline is drawn. We can either:

  • keep the same behaviour, and be more specific about the wording of that option ("Only before cautionary [at end of system]" or something), or
  • make this option more granular (perhaps "At end of system only" with then an additional checkbox for "Only when cautionary is shown" - or something like that)

(These are questions for @bkunda)

Copy link

@bkunda bkunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice feature. Thanks @XiaoMigros!

@its-not-nice its-not-nice self-requested a review January 25, 2024 10:36
@bkunda
Copy link

bkunda commented Jan 26, 2024

@XiaoMigros after discussing this PR further with @oktophonie, we feel this UI arrangement might more accurately reflect what's really going on with double barline behaviour:

Screenshot 2024-01-26 at 4 45 15 pm

Further, I'm fine with these settings remaining under the "Barline" page, so they can stay there for now.

@oktophonie is there anything else we need to add here?

Pls let me know when this is ready for a further review.
Thanks so much!

@XiaoMigros
Copy link
Contributor Author

@bkunda All set for another review!

@bkunda bkunda self-requested a review January 30, 2024 08:59
Copy link

@bkunda bkunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-tested on macOS.
All looks good to go from my perspective!
Thanks so much @XiaoMigros

@cbjeukendrup cbjeukendrup merged commit 4feb119 into musescore:master Feb 9, 2024
@XiaoMigros XiaoMigros deleted the courtesy-barlines branch February 14, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to add double barline before key signature change automatically
4 participants