-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Fix #18941: Styled barlines before signatures #21188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ade5b7a
to
42f89a5
Compare
It might make sense to put these new options in the new 'Clefs, key & time signatures' section now that #20911 has been merged. I'd envisaged the option being expressed something like "Double barline before key|time signatures" with options "Never"/"Always"/"At end of system only". In particular, the "Single barline" option is a bit misleading as it really means "don't change the preceding barline" (which could be anything). There is also a question about cautionaries. Currently, double barlines will be drawn where the relevant "At end of system" option is chosen only if a cautionary is shown there; if you turn "Show cautionary" off, a single barline is drawn. We can either:
(These are questions for @bkunda) |
42f89a5
to
09ef3d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice feature. Thanks @XiaoMigros!
@XiaoMigros after discussing this PR further with @oktophonie, we feel this UI arrangement might more accurately reflect what's really going on with double barline behaviour: ![]() Further, I'm fine with these settings remaining under the "Barline" page, so they can stay there for now. @oktophonie is there anything else we need to add here? Pls let me know when this is ready for a further review. |
09ef3d3
to
d758b29
Compare
@bkunda All set for another review! |
d758b29
to
a0703fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-tested on macOS.
All looks good to go from my perspective!
Thanks so much @XiaoMigros
5c76988
to
68c5c4e
Compare
Resolves: #18941
This PR introduces style settings for drawing barlines in front of key signatures and time signatures: Either to always use single barlines, always use double barlines, or to use double barlines in front of a system change. The default settings haven't been changed so the behavior is the same.