Sticking layout improvements #23825
Merged
Sticking layout improvements #23825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
force-pushed
the
stickingImprovements
branch
from
d75aa18 to
bb54588
Compare
its-not-nice
approved these changes
Jul 30, 2024
|
Huge improvement, thank you!! I don't think this is a show-stopper, but I think the horizontal spacing with slashed note heads looks more uneven than before (Sticking attached to slashed notehead gets pushed to the right) video1649969583.mp4 |
|
Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved |
RomanPudashkin
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #20887
The most significant change introduced by this PR is that sticking marks are aligned throughout the system, not too differently from how lyrics are done.
To this purpose, I initially thought I'd reuse some of the lyrics logic that I've implemented not long ago, but it turns out that that's very lyrics-specific and not easy to generalize. Instead, the much better approach is to generalize the AlignmentLayout logic to also work with groups of items that don't necessarily have the "snapping" property (like dyanmics and hairpins). Now we have a simple function which can align any given group of items, which will have plenty of uses in future and in this case makes it easy to pass the groups of stickings and align them.
Additionally, stickings are now centered on the notehead, rather than left-aligned. Bear in mind when testing @zacjansheski @oktophonie that in order for some of the changes to take effect on existing files a "Reset all styles to default" will be needed.