Skip to content

Conversation

cbjeukendrup
Copy link
Member

@cbjeukendrup cbjeukendrup commented Sep 29, 2024

See #24095, #24644

Resolves only on Windows: #23505
Resolves not yet: #23970
Resolves: #24232
Resolves: #24579
Resolves only on Windows: #24667

May solve some blank screen issues too (https://musescore.org/en/node/368527#comment-1257820)

Relevant Qt commits:
- broken in qt/qtdeclarative@499828b
- perhaps changed a bit in qt/qtdeclarative@205e31d, but not fixed

Qt commit that seemed relevant at first, but didn't turn out to be:
- qt/qtdeclarative@cdc0e5c
On macOS, it causes a problem with disappearing texts, which will take more time to fix. Also, the issues solved by this update affect other OSs more than macOS.

On Linux, it causes crashes whenever OS dialogs are involved (open/save, color picker).

Resolves only on Windows: #23505
Resolves not yet: #23970
Resolves: #24232
Resolves: #24579
@cbjeukendrup
Copy link
Member Author

As discussed, we can actually merge this immediately; on macOS and Linux, there are no changes, and on Windows, only one regression had been found: #24644 (comment) But we decided that the issues solved by this PR outweigh that regression.

@DmitryArefiev
Copy link
Contributor

Tested on Win10
#23505 looks good
#24232 and #24579 - I can't check it properly because was not able to reproduce it before

@DmitryArefiev DmitryArefiev merged commit 81203f7 into 4.4.3 Sep 30, 2024
11 checks passed
@cbjeukendrup cbjeukendrup deleted the port/4.4.3/qt_6.2.9_only_windows branch October 2, 2024 23:59
@cbjeukendrup cbjeukendrup mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants