Skip to content

Conversation

prodoelmit
Copy link
Contributor

@prodoelmit prodoelmit commented Sep 6, 2025

  • Adds additional check to remove timeSig segment from inside mmRest

Resolves: #27582

Fixes the case where removing time signature that is only followed by multi-measure rests (even if it's 1-measure mmRest) crashes the application

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

* Adds additional check to remove timeSig segment from inside mmRest
@zacjansheski
Copy link
Contributor

Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved
#27582 FIXED

@RomanPudashkin
Copy link
Contributor

@prodoelmit thank you!

@RomanPudashkin RomanPudashkin merged commit f1545c7 into musescore:master Sep 10, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash while deleting time signatures.
3 participants