fix(ts/js): fixed behavior of root_dir funcion (issue #4015) #4022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem: ts_ls, vtsls, tsgo LSP do not start for standalone files eslint/biome LSP do not start when there is config file but lock file is absent in workspace directory solution: ts_ls, vtsls, tsgo: Remove redundant truthy check when calling `on_dir(project_root)`. If `project_root` is provided, it will be used as `root_dir`; otherwise, `root_dir` will be `nil`, allowing the LSP to start for standalone files. eslint/biome: added check for config root directory when project root directory not found
justinmk
reviewed
Aug 21, 2025
Comment on lines
+89
to
+90
| -- If project root not found `project_root` will be nil and on_dir function will be called with nil value | ||
| -- to allow LSP to start for standalone TS/JS files. |
There was a problem hiding this comment.
This can be less verbose. Same for other cases where applicable.
Suggested change
| -- If project root not found `project_root` will be nil and on_dir function will be called with nil value | |
| -- to allow LSP to start for standalone TS/JS files. | |
| -- If `project_root=nil`, we still want on_dir() because this server supports "standalone" mode (workspace_required=false). |
|
If lsp/eslint.lua and lsp/biome.lua have chosen |
|
@justinmk , I’ve decided to close this PR, as it only addresses the symptoms of the larger issue that PR #3955 attempted to resolve, but encountered edge cases. At this point, fixing this problem is beyond my current experience, since I believe it is primarily a design issue that requires careful discussion and consideration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is intended to fix issue #4015
Problem:
ts_ls, vtsls, tsgo LSP do not start for standalone files
eslint/biome LSP do not start when there is config file but lock file is absent in workspace directory
Solution:
ts_ls, vtsls, tsgo: Remove redundant truthy check when calling
on_dir(project_root). Ifproject_rootis provided, it will be used asroot_dir; otherwise,root_dirwill benil, allowing the LSP to start for standalone files.eslint/biome: added check for config root directory when project root directory not found
Please, consider that i am a beginner, so I will be grateful for any suggestions for improvements.