Skip to content

fix(dialog/spawnDialog): incorrect return type for optional result #6905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

fix(dialog/spawnDialog): incorrect return type for optional result #6905

merged 1 commit into from
May 12, 2025

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented May 12, 2025

☑️ Resolves

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@ShGKme ShGKme added this to the 9.0.0-rc.1 milestone May 12, 2025
@ShGKme ShGKme requested review from susnux and Antreesy May 12, 2025 09:14
@ShGKme ShGKme self-assigned this May 12, 2025
@ShGKme ShGKme added 3. to review Waiting for reviews feature: functions composables, functions, mixins and other non-components bug Something isn't working labels May 12, 2025
susnux
susnux approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works!

@susnux susnux merged commit 375be0d into main May 12, 2025
25 checks passed
@susnux susnux deleted the fix/dialogs--spawnDialogs--types branch May 12, 2025 10:05
@susnux susnux mentioned this pull request May 12, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews bug Something isn't working feature: functions composables, functions, mixins and other non-components
Projects
None yet
Milestone
9.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

[spawnDialog] Wrong return type if intersection type with undefined
3 participants
@ShGKme @susnux @Antreesy