Fix CKEditor color in darkmode #11665
Conversation
CreatorOfBiontium
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
|
Please sign your commit, heres how to do it: https://github.com/nextcloud/mail/pull/11665/checks?check_run_id=50177525841 and also, the commit message should be fix: ckeditor color in darkmode. https://www.conventionalcommits.org/en/v1.0.0/ thanks again :) |
|
Yes, I will fix it today, I splitted the first pr into 2 late yestrday and I forgot about it :) |
CreatorOfBiontium
force-pushed
the
fix/ckeditor_darkmode
branch
2 times, most recently
from
acb9ebe to
808d010
Compare
|
Just added the fix: toolbar dropdown and height bug push, so for reference: Before: After (this pr): |
|
I noticed there’s an extra commit from Vodyanov in this branch, which shouldn’t be here. I’ll clean it up and force-push so that only my changes remain. Hope its ok |
Added a few styles to fix the colors Signed-off-by: Tobiáš Vašťák <[email protected]> Signed-off-by: Biontium <[email protected]>
Fix toolbar dropdown border radius and a bug that made the toolbar show double height when the list option wrapped into two lines after widening the composer. Signed-off-by: Biontium <[email protected]>
Removed a single line that caused the color picker menu to not display colors in the email composer. Signed-off-by: Biontium <[email protected]>
Added code to display properly the dropdown list elements and the input field for color choosing. Signed-off-by: Biontium <[email protected]>
CreatorOfBiontium
force-pushed
the
fix/ckeditor_darkmode
branch
from
00cebca to
4b40509
Compare
|
Done. The branch has been cleaned up. Hopefully everything looks fine now. Sorry for the confusion. |
|
/backport to stable5.5 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This is the splitted pr for ckeditor changes. This pr contains fix for the CKEditor in darkmode.
Before (on hover):
After (on hover):
