Skip to content

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Sep 2, 2025

Updated the room upon receiving a processRoomListEvent in the NCExternalSignalingController.

Is this the right way to implement this? Not sure if updating is a heavy operation or not. On Android we have the room state updated upon receiving a new capability from the server, which is then reflected in the UI.

Screen.Recording.2025-09-02.at.12.02.31.PM.mov

Updated the room upon receiving a processRoomListEvent in the NCExternalSignalingController.

Signed-off-by: rapterjet2004 <[email protected]>
@rapterjet2004 rapterjet2004 self-assigned this Sep 2, 2025
@rapterjet2004 rapterjet2004 requested review from SystemKeeper and Ivansss and removed request for SystemKeeper September 2, 2025 17:11
@SystemKeeper
Copy link
Collaborator

Cool stuff, thanks! Need to take a closer look of that is the best way to solve, out of my head I am not totally sure.

@Ivansss
Copy link
Member

Ivansss commented Sep 10, 2025

Do you also re-fetch the room from the server whenever you receive an update message from the external signaling on Android?
Even though that solution works, I think the best and most performant solution would be to check the updated attributes included in the update message and update the room locally, without making an additional request to the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide/show inputbar when conversation is locked/unlocked
3 participants