Skip to content

Remove stringstream #3244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2022
Merged

Remove stringstream #3244

merged 1 commit into from
Jan 4, 2022
+32 −14

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Jan 3, 2022

This PR replaces string streams by a direct implementation.

Fixes #3239.

@nlohmann nlohmann marked this pull request as draft January 3, 2022 19:46
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 06ca197 on issue3239_remove_stringstream into 78ddf2b on develop.

@nlohmann nlohmann marked this pull request as ready for review January 3, 2022 21:34
@nlohmann nlohmann self-assigned this Jan 3, 2022
@nlohmann nlohmann added this to the Release 3.10.6 milestone Jan 3, 2022
@nlohmann nlohmann mentioned this pull request Jan 3, 2022
Closed
@nlohmann nlohmann merged commit 9e89c2f into develop Jan 4, 2022
@nlohmann nlohmann deleted the issue3239_remove_stringstream branch January 4, 2022 08:25
gregmarr
gregmarr reviewed Jan 5, 2022
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gregmarr gregmarr gregmarr left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@nlohmann nlohmann

Labels
release item: 🔨 further change
Projects
None yet
Milestone
Release 3.11.0
Development

Successfully merging this pull request may close these issues.

Replace use of standard IO from error handling
3 participants
@nlohmann @coveralls @gregmarr