Fix #4863: skip try_run for LIBCPP_VERSION_OUTPUT during cross compil… #4876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlohmann
requested changes
Jul 31, 2025
nlohmann
reviewed
Jul 31, 2025
nlohmann
reviewed
Jul 31, 2025
nlohmann
reviewed
Jul 31, 2025
|
Please also follow these instructions to satisfy the DCO check. |
hitgil
force-pushed
the
fix-4863-libcpp-version-output
branch
from
0fb89d9 to
0c0b119
Compare
nlohmann
requested changes
Jul 31, 2025
|
Thanks a lot! The CI will be red, because #4871 is not yet merged. Don't worry about that. |
2 tasks
|
Please rebase to the latest develop branch as I just merged #4871. |
added 5 commits
August 1, 2025 09:03
…s compilation Signed-off-by: Hitgirl <[email protected]>
Signed-off-by: Hitgirl <[email protected]>
Signed-off-by: Hitgirl <[email protected]>
Signed-off-by: Hitgirl <[email protected]>
Signed-off-by: Hitgirl <[email protected]>
hitgil
force-pushed
the
fix-4863-libcpp-version-output
branch
from
8dd4ce4 to
6a7768f
Compare
aryanrahar
pushed a commit
to aryanrahar/json-add
that referenced
this pull request
Aug 6, 2025
…s compil… (nlohmann#4876) * Fix nlohmann#4863: skip try_run for LIBCPP_VERSION_OUTPUT during cross compilation Signed-off-by: Hitgirl <[email protected]> * fix nlohmann#4863: handle cross-compiling in libc++ detection gracefully Signed-off-by: Hitgirl <[email protected]> * refactor: move cross-compiling check before cached output detection Signed-off-by: Hitgirl <[email protected]> * refactor: move cross-compiling check before cached output detection Signed-off-by: Hitgirl <[email protected]> * refactor: move cross-compiling check before cached output detection Signed-off-by: Hitgirl <[email protected]> --------- Signed-off-by: Hitgirl <[email protected]> Co-authored-by: Hitgirl <[email protected]>
aryanrahar
pushed a commit
to aryanrahar/json-add
that referenced
this pull request
Aug 7, 2025
…s compil… (nlohmann#4876) * Fix nlohmann#4863: skip try_run for LIBCPP_VERSION_OUTPUT during cross compilation Signed-off-by: Hitgirl <[email protected]> * fix nlohmann#4863: handle cross-compiling in libc++ detection gracefully Signed-off-by: Hitgirl <[email protected]> * refactor: move cross-compiling check before cached output detection Signed-off-by: Hitgirl <[email protected]> * refactor: move cross-compiling check before cached output detection Signed-off-by: Hitgirl <[email protected]> * refactor: move cross-compiling check before cached output detection Signed-off-by: Hitgirl <[email protected]> --------- Signed-off-by: Hitgirl <[email protected]> Co-authored-by: Hitgirl <[email protected]>
aryanrahar
pushed a commit
to aryanrahar/json-add
that referenced
this pull request
Aug 7, 2025
…s compil… (nlohmann#4876) * Fix nlohmann#4863: skip try_run for LIBCPP_VERSION_OUTPUT during cross compilation Signed-off-by: Hitgirl <[email protected]> * fix nlohmann#4863: handle cross-compiling in libc++ detection gracefully Signed-off-by: Hitgirl <[email protected]> * refactor: move cross-compiling check before cached output detection Signed-off-by: Hitgirl <[email protected]> * refactor: move cross-compiling check before cached output detection Signed-off-by: Hitgirl <[email protected]> * refactor: move cross-compiling check before cached output detection Signed-off-by: Hitgirl <[email protected]> --------- Signed-off-by: Hitgirl <[email protected]> Co-authored-by: Hitgirl <[email protected]> Signed-off-by: Aryan Rahar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #4863
Skip
try_run()when cross-compiling, as it leads to configuration errors when detecting the C++ standard library version (LIBCPP_VERSION_OUTPUT).When
CMAKE_CROSSCOMPILINGis set,try_run()fails because it cannot execute the compiled binary on the build host. This patch adds a conditional to bypasstry_run()and sets the fallback value directly, avoiding configuration failure during the first run.make amalgamate. (Not applicable, this is a build script change)