-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
Description
Following #59138 and the introduction of GetOptionsAsFlags
, we might want to verify whether similar changes are needed throughout the codebase, especially where execArgv
is used to filter or propagate options to child processes, etc.
This could be necessary now that Node can receive options via --experimental-default-config-file.
I had a quick look and found these entries, though there are probably more:
Child Process Module
- lib/child_process.js#L148 - Default execArgv assignment for fork operations
- lib/child_process.js#L151 - Eval flag filtering to prevent fork bombing
- lib/child_process.js#L557 - Permission model flag copying to child processes
Cluster Module
- lib/internal/cluster/primary.js#L66 - Cluster worker setup with execArgv inheritance
Watch Mode
- lib/internal/main/watch_mode.js#L44-L50 - Watch flag filtering for process restarts
Note: At the moment, --watch
doesn't seem to work with both the config file and NODE_OPTIONS
.
We might want to remove kAllowedInEnvvar
.
Parse Args Utility
- lib/internal/util/parse_args/parse_args.js#L62-L68 - Main argument detection for eval/print flags
Inspector Utility
- lib/internal/util/inspector.js#L23 - Inspector/debugger flag detection with caching
REPL Module
- lib/internal/repl/utils.js#L291-L297 - Strict mode detection with flag normalization
Benchmark Utilities
- benchmark/common.js#L230 - Benchmark execution arguments combination
Note: Some of the entries I listed probably don’t need any changes, but I’m reporting them to get a second opinion.