Skip to content

Conversation

indutny
Copy link
Member

@indutny indutny commented May 3, 2025

[email protected] optimizes header value parsing on ARM Neon/WASM, and adds support for a protocol callback for use outside of the typical HTTP setting (RTSP/ICE).

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net
  • @nodejs/security-wg

@indutny
Copy link
Member Author

indutny commented May 3, 2025

cc @nodejs/http @nodejs/llhttp

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 3, 2025
@indutny indutny force-pushed the feature/llhttp-9-3-0 branch from 18ff350 to 71e7ad2 Compare May 3, 2025 18:01
[email protected] optimizes header value parsing on ARM Neon/WASM, and adds
support for a protocol callback for use outside of the typical HTTP
setting (RTSP/ICE).
@indutny indutny force-pushed the feature/llhttp-9-3-0 branch from 71e7ad2 to d41e8cb Compare May 3, 2025 18:44
Copy link

codecov bot commented May 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (723d7bb) to head (d41e8cb).
Report is 317 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58144      +/-   ##
==========================================
- Coverage   90.17%   90.17%   -0.01%     
==========================================
  Files         630      630              
  Lines      186473   186473              
  Branches    36613    36614       +1     
==========================================
- Hits       168160   168151       -9     
+ Misses      11128    11121       -7     
- Partials     7185     7201      +16     
Files with missing lines Coverage Δ
src/node_http_parser.cc 83.02% <ø> (ø)

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels May 5, 2025
@mcollina
Copy link
Member

mcollina commented May 5, 2025

Marked as dont-land-on-v20.x because it has llhttp v8.

@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 5, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/58144
✔  Done loading data for nodejs/node/pull/58144
----------------------------------- PR info ------------------------------------
Title      deps: update llhttp to 9.3.0 (#58144)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     indutny:feature/llhttp-9-3-0 -> nodejs:main
Labels     lib / src, needs-ci, dont-land-on-v20.x
Commits    1
 - deps: update llhttp to 9.3.0
Committers 1
 - Fedor Indutny <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/58144
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58144
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 03 May 2025 17:49:33 GMT
   ✔  Approvals: 4
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/58144#pullrequestreview-2813280324
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/58144#pullrequestreview-2813281787
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/58144#pullrequestreview-2813479866
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/58144#pullrequestreview-2813582968
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/14842769407

@mcollina mcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 6, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 6, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2025
@nodejs-github-bot nodejs-github-bot merged commit 4454d09 into nodejs:main May 7, 2025
72 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4454d09

targos pushed a commit that referenced this pull request May 16, 2025
[email protected] optimizes header value parsing on ARM Neon/WASM, and adds
support for a protocol callback for use outside of the typical HTTP
setting (RTSP/ICE).

PR-URL: #58144
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@aduh95 aduh95 added lts-watch-v20.x PRs that may need to be released in v20.x and removed dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels May 28, 2025
@marco-ippolito marco-ippolito removed the lts-watch-v20.x PRs that may need to be released in v20.x label Jun 5, 2025
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
[email protected] optimizes header value parsing on ARM Neon/WASM, and adds
support for a protocol callback for use outside of the typical HTTP
setting (RTSP/ICE).

PR-URL: #58144
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
[email protected] optimizes header value parsing on ARM Neon/WASM, and adds
support for a protocol callback for use outside of the typical HTTP
setting (RTSP/ICE).

PR-URL: #58144
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@marco-ippolito marco-ippolito added the lts-watch-v20.x PRs that may need to be released in v20.x label Jun 10, 2025
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
[email protected] optimizes header value parsing on ARM Neon/WASM, and adds
support for a protocol callback for use outside of the typical HTTP
setting (RTSP/ICE).

PR-URL: #58144
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 14, 2025
[email protected] optimizes header value parsing on ARM Neon/WASM, and adds
support for a protocol callback for use outside of the typical HTTP
setting (RTSP/ICE).

PR-URL: #58144
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. lts-watch-v20.x PRs that may need to be released in v20.x needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants