Skip to content

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 20, 2025

Those have been failing for a while, and no one has managed to find out how to fix it. Keeping a failing job that we ignore the result is really not healthy, and just wasteful at this point, let's disable it.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@aduh95 aduh95 changed the title tools: disable failing coverage jobs [v22.x] tools: disable failing coverage jobs Jun 20, 2025
@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Jun 20, 2025
@aduh95 aduh95 requested a review from a team June 20, 2025 07:16
@aduh95 aduh95 force-pushed the skip-coverage-jobs branch from ce08a5e to 27fc963 Compare June 20, 2025 07:35
@marco-ippolito
Copy link
Member

We probably should backport this to v20

PR-URL: nodejs#58770
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@aduh95 aduh95 force-pushed the skip-coverage-jobs branch from 27fc963 to b7feda9 Compare June 23, 2025 10:16
@aduh95
Copy link
Contributor Author

aduh95 commented Jun 23, 2025

Landed in b7feda9

@aduh95 aduh95 merged commit b7feda9 into nodejs:v22.x-staging Jun 23, 2025
14 checks passed
@aduh95 aduh95 deleted the skip-coverage-jobs branch June 23, 2025 10:17
aduh95 added a commit that referenced this pull request Jun 23, 2025
PR-URL: #58770
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@aduh95 aduh95 added the backported-to-v20.x PRs backported to the v20.x-staging branch. label Jun 23, 2025
RafaelGSS pushed a commit that referenced this pull request Jul 15, 2025
PR-URL: #58770
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported-to-v20.x PRs backported to the v20.x-staging branch. meta Issues and PRs related to the general management of the project. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants