Skip to content

http: don't set keepAliveTimeoutBuffer twice. #59773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

http: don't set keepAliveTimeoutBuffer twice. #59773

wants to merge 1 commit into from
+3 −7

Conversation

ronag
Copy link
Member

@ronag ronag commented Sep 5, 2025

It's already set once through storeHTTPOptions

@ronag ronag added the http Issues or PRs related to the http subsystem. label Sep 5, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 5, 2025
@ronag ronag force-pushed the http-timeout-buffer branch from 24d752a to fb2e373 Compare September 5, 2025 16:30
@codecov Codecov
Copy link

codecov bot commented Sep 5, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.96%. Comparing base (961554c) to head (79e9189).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59773      +/-   ##
==========================================
+ Coverage   89.93%   89.96%   +0.02%     
==========================================
  Files         667      667              
  Lines      196775   197203     +428     
  Branches    38409    38525     +116     
==========================================
+ Hits       176977   177411     +434     
+ Misses      12247    12234      -13     
- Partials     7551     7558       +7
Files with missing lines Coverage Δ
lib/_http_server.js 97.10% <100.00%> (+0.15%) ⬆️

... and 53 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina
mcollina approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gurgunday
gurgunday approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69094/

@ronag
http: don't set keepAliveTimeoutBuffer twice.
79e9189 
It's already set once through storeHTTPOptions
@ronag ronag force-pushed the http-timeout-buffer branch from fb2e373 to 79e9189 Compare September 6, 2025 13:34
@haramj haramj mentioned this pull request Sep 6, 2025
Open
gurgunday
gurgunday approved these changes Sep 6, 2025
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@ShogunPanda ShogunPanda Awaiting requested review from ShogunPanda

+1 more reviewer

@gurgunday gurgunday gurgunday approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronag @nodejs-github-bot @mcollina @Ethan-Arrowood @gurgunday