http: unbreak keepAliveTimeoutBuffer #59784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
ronag
force-pushed
the
guard-keepalive
branch
from
5fce091 to
804bbe7
Compare
Adds a guard.
ronag
force-pushed
the
guard-keepalive
branch
from
804bbe7 to
0abd988
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59784 +/- ##
==========================================
+ Coverage 89.95% 89.96% +0.01%
==========================================
Files 667 667
Lines 196776 197212 +436
Branches 38409 38530 +121
==========================================
+ Hits 177006 177427 +421
- Misses 12198 12204 +6
- Partials 7572 7581 +9
🚀 New features to boost your workflow:
|
github-actions
bot
added
request-ci-failed
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/17531940843 |
Flarna
approved these changes
Sep 7, 2025
| const keepAliveTimeout = NumberIsFinite(server.keepAliveTimeout) && server.keepAliveTimeout >= 0 ? | ||
| server.keepAliveTimeout : 0; | ||
| const keepAliveTimeoutBuffer = NumberIsFinite(server.keepAliveTimeoutBuffer) && server.keepAliveTimeoutBuffer >= 0 ? | ||
| server.keepAliveTimeoutBuffer : 1e3; |
There was a problem hiding this comment.
Maybe move the 1e3 into a shared const and use it at all places.
There was a problem hiding this comment.
Because I don't want to break. It was 1e3 pre keepAliveTimeoutBuffer.
There was a problem hiding this comment.
I don't understand your comment. Why is using a shard constant instead of duplicating the literal breaking?
ronag
added
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
ronag
added
author ready
RafaelGSS
approved these changes
Sep 9, 2025
ronag
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7d0f6be |
targos
pushed a commit
that referenced
this pull request
Sep 10, 2025
Adds a guard. PR-URL: #59784 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If keepAliveTimeoutBuffer is set to undefined (for whatever reason) or if not set at all we will throw.
This adds a guard.