-
Notifications
You must be signed in to change notification settings - Fork 8
deps: update minimatch to 10.0.3 #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the minimatch package's dependencies to use the new scoped @isaacs versions of balanced-match and brace-expansion. The code for these modules is refactored to use ES module syntax, named exports, and improved variable handling. The package.json is updated to reflect the new dependencies and devDependency versions. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (2)
🧰 Additional context used🪛 Biome (1.9.4)deps/minimatch/index.js[error] 10-10: Redundant use strict directive. The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it. (lint/suspicious/noRedundantUseStrict) [error] 72-72: Redundant use strict directive. The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it. (lint/suspicious/noRedundantUseStrict) ⏰ Context from checks skipped due to timeout of 90000ms (5)
🔇 Additional comments (6)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files skipped due to size limits:
- deps/minimatch/package-lock.json
- deps/minimatch/dist/commonjs/index.js.map
- deps/minimatch/dist/esm/index.js.map
Looks good to me 🤙
💡 To request another review, post a new comment with "/windsurf-review".
PR-URL: #328 Reviewed-By: Santiago Gimeno <[email protected]>
Already landed in 6d6b58a |
Fast track of nodejs/node#58712
Summary by CodeRabbit
Chores
Refactor
No changes to user-facing features or behavior.